98194 - table or cell background choice in color picker does not always change to cell option when a cell is selected

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[TucsonTester2]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.3+) Gecko/20010830
Netscape6/6.1b1
BuildID:    20010830

After changing the table background color using the properties window I could
not change the cell background color using the toolbar.  What I did after
changing the table's background color using the properties menu was highlight a
single cell using the ctrl-click.  Once I highlighted that cell I clicked on the
"table or cell background" background button on the toolbar. Once I chose a
color the entire table background changed color.

Reproducible: Always
Steps to Reproduce:
1.Open composer
2.insert a 3x3 100pixel table
3.Double-click on the table and click on the table background tab
4.Change the table background color to black
5.Ctrl-click on one of the table's cells
6.click on the "table or cell background" button on the toolbar and choose white.

Actual Results:  The whole table changes color instead of just the selected
cell.  In order to change the cell's background color I need to go into the
table/cell properties and change it in there.

Expected Results:  I would expect that only the cell would change color since
only that is selected.

Comment 1

[TucsonTester2]

What I noticed just recently was that the table cell background properties
window always defaults to table if you have changed the table's background
color.  It doesn't matter what you select in a table after you change the table
background color, it will always default to table.  I would expect that if I
have just a cell selected that composer would know I only want to change the
cell(s) background color.

Comment 2

[Kathleen :Brade]

-->cmanske

Comment 3

[Charles Manske]

Right, the radio button for "table" is set as default if the table already has
background color. You are saying that it should initialize based on selection
instead.
These radio buttons are very likely going to be removed during the major color 
picker rewrite occurs (bug 90670).

Comment 4

[Charles Manske]

load balancing

Comment 5

[Charles Manske]

changing milestone

Comment 6

[Charles Manske]

Attachment: patch v1

Add a new attribute "SelectedType" to retain what table element was selected
and use that to set radio button in the Color Picker dialog.

Comment 7

[Charles Manske]

This is an easy fix with good user interface value -- the user definitely
expects to set the color on the table element that is selected.

Comment 8

[Kathleen :Brade]

Comment on attachment 94645 [details] [diff] [review]
patch v1

r=brade

Comment 9

[Joe Hewitt (gone)]

Comment on attachment 94645 [details] [diff] [review]
patch v1

sr=hewitt

Comment 10

[Charles Manske]

checked into 1.2 trunk