982022 - Page helper application icon is no longer displayed in the URL bar (Aurora 29.0)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Flaviu Cos]

Environment: 
Device: Google Nexus 5 (Android 4.4.2);
Build: Aurora 29.0a2 (2014-03-10);

Steps to reproduce:
1. Go to m.youtube.com or maps.google.com;
3. Check if the helper app is present.

Expected result:
The helper app is present in the url bar.

Actual result:
The helper app is not present in the url bar.

Note:
Not reproducible on latest Nightly build.

Comment 1

[Flaviu Cos]

Regression window made on aurora builds:
Last good build: 2014-02-24
First bad build: 2014-02-25

Pushlog:
http://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=f8ec94d3ab7c&tochange=2d1f9c800085

Comment 2

[Aaron Train [:aaronmt]]

I get a similar range http://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=744c8107734f&tochange=f8ec94d3ab7c

This is reproducible.

Nothing really stands out :/

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

We didn't need to override this. This code is a little (a lot) dangerous, but its all gone on central now :)

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8389646 [details] [diff] [review]
Patch

Review of attachment 8389646 [details] [diff] [review]:
-----------------------------------------------------------------

I will take your word for it :)

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch

Whoops. Removed something necessary while cleaning up my logging :)

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8389650 [details] [diff] [review]
Patch

Review of attachment 8389650 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, now it becomes clearer :)

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 8389650 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 917942
User impact if declined: Helper Apps are busted (and probably some other things)
Testing completed (on m-c, etc.): Tested locally. We've changed this code significantly on central so that this isn't needed there.
Risk to taking this patch (and alternatives if risky): Low risk. Just using the parent classes (exactly same) implementation
String or IDL/UUID changes made by this patch: none.

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b8e50425d63

Comment 9

[Catalin Suciu [:csuciu]]

Verified fixed on Aurora 30.0a2 (2014-04-02)
Doesn't reproduce on Firefox 29 Beta 4