982075 - addEntriesToListFile() in buildlist.py makes builds non-deterministic

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Georg Koppen]

When calling addEntriesToListFile() it can happen that the resulting entries in different builds are in different order. This does not fit to the goal of deterministic builds and should therefore get fixed.

Comment 1

[Georg Koppen]

Attachment: make addEntriesToListFile() deterministic

test_buildlist.py is still happy. Seems good to go then, I hope.

Comment 2

[Gregory Szorc [:gps]]

I won't be able to review this until next week. Reassign to :glandium or :mshal if you want a speedier review.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8389139 [details] [diff] [review]
make addEntriesToListFile() deterministic

Review of attachment 8389139 [details] [diff] [review]:
-----------------------------------------------------------------

I'll just r+ this since it's trivial.

::: python/mozbuild/mozbuild/action/buildlist.py
@@ +34,1 @@
>      f.close()

can you swap this to be:
with open(listFile, 'w') as f:
  f.write(...)
and ditch the close while you're here?

Comment 4

[Georg Koppen]

Attachment: changed reviewed code as requested

Thanks for the review. I changed the code accordingly.

Comment 5

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f6b2d2b2000

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8f6b2d2b2000