Closed Bug 982146 Opened 10 years ago Closed 10 years ago

Clean up SyncRunnable wait code

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(1 file)

Patch, v1
1.63 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
Attached patch Patch, v1 — — Splinter Review 
Our condition variables don't remain triggered like some other event implementations (e.g. manual-reset Windows Event objects). You have to watch your own condition flag.
Attachment #8389235 - Flags: review?(benjamin)
Comment on attachment 8389235 [details] [diff] [review]
Patch, v1

As discussed on IRC, I don't think there is actually a bug here: we cannot signal the monitor until the task is complete and we can't enter the monitor until we're waiting.

However this patch with the explicit condition is better in general and we should do it.
Attachment #8389235 - Flags: review?(benjamin) → review+
Yep, sorry, I read too quickly!

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed30fc4d3e17
Summary: SyncRunnable doesn't wait correctly → Clean up SyncRunnable wait code
https://hg.mozilla.org/mozilla-central/rev/ed30fc4d3e17
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.