98218 - [DOCTYPE]mode detection for HTML doc with XML-decl is confused

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  The mode detection for an HTML document that has an XML
declaration (a pseudo-PI) is confused.  It puts the parser into standard mode
but somehow layout stays in quirks mode:

http://www.bath.ac.uk/%7Epy8ieh/cgi/compat-test.pl?DOCTYPE=%3C%3Fxml+version%3D%221.0%22%3F%3E&MODE=full

The tests should not contradict each other -- they should show the same result as

http://www.bath.ac.uk/%7Epy8ieh/cgi/compat-test.pl?DOCTYPE=%3C%21DOCTYPE+HTML+PUBLIC+%22-%2F%2FW3C%2F%2FDTD+XHTML+1.0+Strict%2F%2FEN%22%3E&MODE=full

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note that this applies only to documents sent as text/html, not to ones sent as
text/xml.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: well-formed XML testcase, as text/xml

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: same testcase, but as text/html

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I really don't know what's preventing the parser from propagating the mode to
layout, but I'm worried that it has something to do with "treating it as XML".

Comment 5

[harishd]

--> 0.9.5

Comment 6

[harishd]

--> 0.9.6

Comment 7

[harishd]

Out of time :-( Moving to 0.9.7

Comment 8

[Andreas M. "Clarence" Schneider]

WFM if I add |<!DOCTYPE >|. AIUI layout gets the mode in
HTMLContentSink::AddDocTypeDecl() and stays in quirks mode if the content sink
gets no doctype node.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The mode should be determined in nsParser::DetermineParseMode.  (I wanted to
unify that with the doctype token handling, but the parser was just too
complicated.)

Comment 10

[harishd]

Attachment: set layout mode whether a DOCTYPE exists or not

Comment 11

[Christopher Hoess (gone)]

Woo hoo!  A fix!

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 59405 [details] [diff] [review]
set layout mode whether a DOCTYPE exists or not

sr=jst

Comment 13

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 59405 [details] [diff] [review]
set layout mode whether a DOCTYPE exists or not

r=heikki

Comment 14

[harishd]

FIXED.

Comment 15

[Moied]

verified fixed with build ID 20020117 on win2k and fix checked in cvs (rev 3.502)