982189 - Readonly input type="number" can still be changed through arrows

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Cork]

Attachment: testcase

Input field type number can still be changed through the arrows even if readonly is set.

STR:
 1. Load a new clean profile
 2. Load testcase
 3. Click the up or down arrow in the input field

Expected result:
 Nothing should happen as the field is readonly.

Actual result:
 The value of the field is modified.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Make Input type="number" not changing with arrows while immutable

This should do the trick. The element wasn't checking at all if it was mutable.

Comment 3

[:Gijs (he/him)]

(I noted this in the dupe, but the patch seems to address the keyboard up/down arrows only (which also mutate the value, even if readonly), not the mouse input case)

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

OK, I'll work on the rest then (the arrows are still broken with the patch above). Can someone assign me this bug? Thanks!

Comment 5

[:Gijs (he/him)]

Great, thanks!

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Fix Input type="number" immutability

OK this should work! Thank you.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 8398686 [details] [diff] [review]
Fix Input type="number" immutability

Looks good!

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Pushed to Try server (I accidentally used the message from another patch):
https://tbpl.mozilla.org/?tree=Try&rev=7d549b6716c0

The mochitest-dt failed for some weird reason, re-pushed again here:
https://tbpl.mozilla.org/?tree=Try&rev=3af9cdc30088

Everything seems fine.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a9161c20a4d

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a9161c20a4d

Comment 11

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified using the testcase that the value can no longer be modified using the spin buttons or the up / down arrow keys on latest Nightly (buildID: 20140427030204) under Win 7 64-bit, Ubuntu 32-bit and Mac OSX 10.8.5.

Comment 14

[Petruta Horea [:phorea], Desktop Test Engineering]

Agi, shouldn't this be uplifted to beta considering the increasing no of duplicates?

Comment 16

[[ex-Mozilla] Agi Sferro | :agi]

Comment on attachment 8398686 [details] [diff] [review]
Fix Input type="number" immutability

I was thinking about it. Let's try.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 935506
User impact if declined: Number input can be changed even if disabled
Testing completed (on m-c, etc.):  the patch has been verified and has been in m-c for a few days now
Risk to taking this patch (and alternatives if risky): the patch is reasonably safe, shouldn't pose any risk
String or IDL/UUID changes made by this patch: none

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8398686 [details] [diff] [review]
Fix Input type="number" immutability

We're in our final week of taking speculative fixes on Beta so we'll take this and make sure that we get the most bake time before ship. Will mark for tracking so this stays on our radar should there be any regressions or backout needed.

Comment 18

[[ex-Mozilla] Agi Sferro | :agi]

Thanks for the approval Lukas. I just applied the patch on my local copy of mozilla-beta and everything seems fine. 

Thank you!

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dcd4cf44e61b

This landed on trunk during the Gecko31 cycle, so this is already fixed on Aurora.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/dcd4cf44e61b

Comment 21

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Marking as verified on 31 based on comment 11.

Comment 22

[Leagnus]

Still can see spinner's arrows in FF 34
<input placeholder="zzz" class="zzz" id="zzzz" name="zzzzz" readonly="True" step="0.01" type="number">

Chrome 37.0.2062.120 m hides them.

Comment 23

[Leagnus]

Sorry, input[type="number"][readonly] {
		-moz-appearance: textfield;
	}
	input[type="number"][readonly]::-webkit-outer-spin-button,
	input[type="number"][readonly]::-webkit-inner-spin-button {
		-webkit-appearance: none;
	}
works well.