Closed
Bug 982190
Opened 10 years ago
Closed 10 years ago
Allow addons to specify custom filter 'up' image
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox30 fixed, firefox31 fixed)
RESOLVED
FIXED
Firefox 31
People
(Reporter: jdover, Assigned: jdover)
References
Details
Attachments
(1 file, 1 obsolete file)
10.52 KB,
patch
|
jdover
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Addons should be able to specify their own 'up' icon to be used in the filter navigation with an API like: Home.panels.register("my-panel", { title: "My Panel", layout: Home.panels.Layout.FRAME, views: [{ type: Home.panels.View.LIST, dataset: "my-data", backImageUrl: "http://example.com/back-image.png" }] });
Assignee | ||
Comment 1•10 years ago
|
||
Addressed comments from bug 975055, comment #41
Attachment #8389336 -
Flags: review?(lucasr.at.mozilla)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8389336 [details] [diff] [review] patch Review of attachment 8389336 [details] [diff] [review]: ----------------------------------------------------------------- Great. ::: mobile/android/base/home/PanelBackItemView.java @@ +6,5 @@ > package org.mozilla.gecko.home; > > import org.mozilla.gecko.R; > import org.mozilla.gecko.home.PanelLayout.FilterDetail; > +import org.mozilla.gecko.home.PanelLayout.FilterManager; Unused.
Attachment #8389336 -
Flags: review?(lucasr.at.mozilla) → review+
Comment 3•10 years ago
|
||
I assume this patch doesn't require any change on the JS side? Have you tested this with an actual add-on?
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Lucas Rocha (:lucasr) from comment #3) > I assume this patch doesn't require any change on the JS side? Have you > tested this with an actual add-on? Yes, I did find one bug though where if the backImageUrl isn't specified there was an error with Picasso. I forgot that JSON#optString defaults to an empty string rather than null. Fixed in this patch.
Attachment #8389336 -
Attachment is obsolete: true
Attachment #8392309 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b4a1adc469bd
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b4a1adc469bd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Comment 7•10 years ago
|
||
Comment on attachment 8392309 [details] [diff] [review] patch Note to release managers: I'm requesting uplift for a series of Firefox Hub bugs. The main fixes we need are in bugs at the end of the series, but trying to rebase those patches proved difficult and risky, so I think we should just uplift the dependecies. Note to sheriffs: I have a local patch series that I can land on aurora when these bugs all get approval. [Approval Request Comment] Bug caused by (feature/regressing bug #): dependency for initial Firefox Hub release (promoted feed add-ons in fx30) User impact if declined: panels won't update when data changes Testing completed (on m-c, etc.): baked on m-c Risk to taking this patch (and alternatives if risky): only affects dynamic panels, need an add-on to trigger this String or IDL/UUID changes made by this patch: none
Attachment #8392309 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8392309 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d85cff6f6ade
status-firefox30:
--- → fixed
status-firefox31:
--- → fixed
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•