982205 - Hide the facebook oauth frame so that we don't pay during painting

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Everytime there's an iframe that we might need to draw we go down a relatively expensive path (Telling the background color to compositor shows up). Avoid that by making the oauth frame hidden.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

https://github.com/mozilla-b2g/gaia/pull/17099

Comment 2

[Jose Manuel Cantera]

Cristian,

Could you have a look at this, whenever you get the chance?

Comment 4

[Cristian Rodriguez (:crdlc)]

Jeff, please put your pr under review although it looks nice because of FTU is working with the same approach

https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/ftu/index.html#L806

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: d331e651526b559028f21b662749edb3e419c216.patch

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8391192 [details] [diff] [review]
d331e651526b559028f21b662749edb3e419c216.patch

LGTM

Comment 7

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/069cae26749e9a054682e1045f10d8efbb94d93b

Comment 8

[Jason Smith [:jsmith]]

We've deciding to not block on this since Milan thinks we might be able to live with some checkerboarding for 1.4 (going to confirm with QC to be sure). But this is definitely worth asking for approval on.