982373 - Leak of nsROCSSPrimitiveValue on early return from nsComputedDOMStyle::DoGetTextDecoration

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[Andrew McCreight [:mccr8]]

Easy fix.  I manually audited every |new| in nsComputedDOMStyle.cpp, and the rest look okay to me.

Comment 1

[Daniel Holbert [:dholbert]]

Yup, easy fix; we can just move the |val| decl down below the early returns.

mccr8, did you want to take this? I'll be happy to review, if so; otherwise, I'm happy to take.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> mccr8, did you want to take this?

(missed that you assigned it to yourself; sorry for the unnecessary noise. :))

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Don't leak val when we return early from nsComputedDOMStyle::DoGetTextDecoration().

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8389939 [details] [diff] [review]
Don't leak val when we return early from nsComputedDOMStyle::DoGetTextDecoration().

Looks good to me.

Comment 5

[Andrew McCreight [:mccr8]]

try: https://tbpl.mozilla.org/?tree=Try&rev=574500da56fc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae03abb86737

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ae03abb86737