982377 - [Camera][Gecko] Improve camera logging

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Right now everything goes through PRLog, but on Gonk we can do better, and make the logging output more consistent with the output from other modules.

Also, the DOM_CAMERA_LOGT macros are almost always used to log function and line numbers--this can be balled into the macros themselves to reduce duplications.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

- make it possible to easily log DOM-facing function calls/callbacks, even when all other logging is disabled.

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

- make it possible to enable logging using a pref, so that end-users can enable debugging
- make it possible to enable logging from Gaia

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: WIP

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Apply 1st. WIP - add debug Settings listener, v1

The first of three patches, all bitrotted, posted here so that others with more time may take them up.

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Apply 2nd. WIP - breaks statics (including Settings listener) out to its own file

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Apply 3rd. WIP - improved use of Gonk logging functions

This patch adds %s:%d => __PRETTY_FUNCTION__, __LINE__ to DOM_CAMERA_LOGT calls implicitly. It also makes use of the Gonk LOG_TAG features on that platform (and emulates them on others).

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

Note that the above changes still make use of changing logging level on the fly without an atomic, which [1] suggests is a problem -- even if it seems benign.

1. https://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong

Comment 8

[BMO Automation]

Firefox OS is not being worked on