982461 - Support launching an intent to the current application package

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Attachment: patch

With this patch, my add-on can simply do this to open an intent:

  let msg = {
    type: "Intent:Open",
    className: "org.mozilla.gecko.home.HomePanelPicker"
  };
  sendMessageToJava(msg);

Without this patch, I would need to pass in the package name for the app, and an add-on doesn't know that.

This will also be useful to us when we move this feature into the browser, so that we won't need to pre-process things to avoid opening the picker in the wrong version of fennec.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 8389573 [details] [diff] [review]
patch

Review of attachment 8389573 [details] [diff] [review]:
-----------------------------------------------------------------

I hate these methods :)

::: mobile/android/base/GeckoAppShell.java
@@ +1144,5 @@
>          if (intent == null) {
>              return false;
>          }
>  
> +        if (className.length() > 0) {

Lets flip these to TextUtils.isEmpty(). Also, they aren't documented apparently. Their names are pretty self explanatory, but would be nice to just toss them in so the docs match the function signature.

@@ +1148,5 @@
> +        if (className.length() > 0) {
> +            if (packageName.length() > 0) {
> +                intent.setClassName(packageName, className);
> +            } else {
> +                intent.setClassName(context, className);

Add a little note that we're assuming the packageName is the Fennec's.

Comment 2

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/8de8e275a35b

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8de8e275a35b