982464 - WebGL Extension aren't neutered after context lost.

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[u480271]

Attachment: Disable extension functionality after a context lost happens.

Fixes failures for
https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-lost-restored.html

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8389593 [details] [diff] [review]
Disable extension functionality after a context lost happens.

Review of attachment 8389593 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLExtensionDebugShaders.cpp
@@ +26,5 @@
>  WebGLExtensionDebugShaders::GetTranslatedShaderSource(WebGLShader* shader,
>                                                        nsAString& retval)
>  {
> +    if (mIsLost)
> +        return;

This should be an INVALID_OPERATION. [1]

::: content/canvas/src/WebGLExtensionDrawBuffers.cpp
@@ +50,5 @@
>  
>  void WebGLExtensionDrawBuffers::DrawBuffersWEBGL(const dom::Sequence<GLenum>& buffers)
>  {
> +    if (mIsLost)
> +        return;

[1]

::: content/canvas/src/WebGLExtensionInstancedArrays.cpp
@@ +24,5 @@
>  void
>  WebGLExtensionInstancedArrays::DrawArraysInstancedANGLE(GLenum mode, GLint first,
>                                                          GLsizei count, GLsizei primcount)
>  {
> +    if (mIsLost) {

[1] here and below

::: content/canvas/src/WebGLExtensionVertexArray.cpp
@@ +25,5 @@
>  
>  already_AddRefed<WebGLVertexArray> WebGLExtensionVertexArray::CreateVertexArrayOES()
>  {
> +    if (mIsLost) {
> +        mContext->GenerateWarning("CreateVertexArrayOES: Extension is lost. Returning NULL.");

[1] here and below

Comment 3

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=ca42f1349342

Comment 4

[u480271]

Attachment: Disable extension functionality after a context lost happens.

Address review from Jeff. Calls to lost extensions result in InvalidOperation.

Comment 5

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=ae0be1c58985

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8389629 [details] [diff] [review]
Disable extension functionality after a context lost happens.

Review of attachment 8389629 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLExtensionDebugShaders.cpp
@@ +27,5 @@
>                                                        nsAString& retval)
>  {
> +    if (mIsLost)
> +        return mContext->ErrorInvalidOperation("getTranslatedShaderSource: "
> +                                               "Extension is lost.");

Multi-line expression inside an if branch deserves {} brackets.

::: content/canvas/src/WebGLExtensionInstancedArrays.cpp
@@ +25,5 @@
>  WebGLExtensionInstancedArrays::DrawArraysInstancedANGLE(GLenum mode, GLint first,
>                                                          GLsizei count, GLsizei primcount)
>  {
> +    if (mIsLost)
> +        return mContext->ErrorInvalidOperation("DrawArraysInstancedANGLE: Extension is lost.");

This function name should be lowercase (what JS sees), here and below.

::: content/canvas/src/WebGLExtensionVertexArray.cpp
@@ +25,5 @@
>  
>  already_AddRefed<WebGLVertexArray> WebGLExtensionVertexArray::CreateVertexArrayOES()
>  {
> +    if (mIsLost) {
> +        mContext->ErrorInvalidOperation("CreateVertexArrayOES: Extension is lost. Returning NULL.");

This function name should be lowercase (what JS sees), here and below.

Comment 7

[u480271]

Attachment: Disable extension functionality after a context lost happens.

Changed warnings to errors, as per review comments.

Comment 8

[u480271]

Attachment: Disable extension functionality after a context lost happens.

Review comments.

Comment 9

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=660155262545

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cef5e3248787

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cef5e3248787