Closed
Bug 982476
Opened 11 years ago
Closed 11 years ago
Clamp the viewport to maximum allowed offscreen rendertarget/texture size.
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
DUPLICATE
of bug 847714
People
(Reporter: u480271, Assigned: u480271)
References
Details
Attachments
(1 file)
22.18 KB,
patch
|
jgilbert
:
review-
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8389596 -
Flags: review?(jgilbert)
Comment 2•11 years ago
|
||
Comment on attachment 8389596 [details] [diff] [review]
Clamp the offscreen size to maximum allowed.
Review of attachment 8389596 [details] [diff] [review]:
-----------------------------------------------------------------
This is more invasive than the change needs to be.
Attachment #8389596 -
Flags: review?(jgilbert) → review-
Comment 3•11 years ago
|
||
From the title and skimming the patch, I can't tell if this is a strict duplicate of bug 847714. If it is, let's mark this as DUPE, and finish the other bug.
It appears like a DUPE. I disagree that this is more invasive than it needs to be. Can you explain more?
Flags: needinfo?(jgilbert)
Comment 5•11 years ago
|
||
(In reply to Dan Glastonbury :djg :kamidphish from comment #4)
> It appears like a DUPE. I disagree that this is more invasive than it needs
> to be. Can you explain more?
Compare it to the patch with similar functionality in bug 847714, where all the changes are in WebGLContext.h/cpp.
Flags: needinfo?(jgilbert)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•