Closed Bug 982541 Opened 7 years ago Closed 7 years ago

Update OscillatorNode.{start, stop} to have the first argument optional and default to zero

Categories

(Core :: Web Audio, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: padenot, Assigned: padenot)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Duplicate of this bug: 982537
Comment on attachment 8389674 [details] [diff] [review]
Update OscillatorNode.{start, stop} to have the first argument optional and default to zero. r=

Review of attachment 8389674 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/test/test_oscillatorNode.html
@@ +51,5 @@
>  
> +  var gotException = false;
> +  try {
> +    osc.start();
> +    osc.stop();

Please test these separately in two try/catch blocks.

If you feel like it, you can even add a expectNoException helper function to webaudio.js for the logic.

r=me either way.
Attachment #8389674 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/fdbf79a891de
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.