Update OscillatorNode.{start, stop} to have the first argument optional and default to zero

RESOLVED FIXED in mozilla30

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

({dev-doc-complete})

unspecified
mozilla30
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Duplicate of this bug: 982537

Comment 3

5 years ago
Comment on attachment 8389674 [details] [diff] [review]
Update OscillatorNode.{start, stop} to have the first argument optional and default to zero. r=

Review of attachment 8389674 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/test/test_oscillatorNode.html
@@ +51,5 @@
>  
> +  var gotException = false;
> +  try {
> +    osc.start();
> +    osc.stop();

Please test these separately in two try/catch blocks.

If you feel like it, you can even add a expectNoException helper function to webaudio.js for the logic.

r=me either way.
Attachment #8389674 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/fdbf79a891de
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.