982541 - Update OscillatorNode.{start, stop} to have the first argument optional and default to zero

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Paul Adenot (:padenot)]

Discussion: http://lists.w3.org/Archives/Public/public-audio/2013OctDec/0034.html
Spec bug: https://github.com/WebAudio/web-audio-api/issues/249

Comment 1

[Paul Adenot (:padenot)]

Attachment: Update OscillatorNode.{start, stop} to have the first argument optional and default to zero. r=

Comment 3

[(no longer active)]

Comment on attachment 8389674 [details] [diff] [review]
Update OscillatorNode.{start, stop} to have the first argument optional and default to zero. r=

Review of attachment 8389674 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/test/test_oscillatorNode.html
@@ +51,5 @@
>  
> +  var gotException = false;
> +  try {
> +    osc.start();
> +    osc.stop();

Please test these separately in two try/catch blocks.

If you feel like it, you can even add a expectNoException helper function to webaudio.js for the logic.

r=me either way.

Comment 4

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fdbf79a891de

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fdbf79a891de

Comment 6

[Jean-Yves Perrier [:teoli]]

Doc updated:
https://developer.mozilla.org/en-US/docs/Web/API/OscillatorNode.start
https://developer.mozilla.org/en-US/docs/Web/API/OscillatorNode.stop
and
https://developer.mozilla.org/en-US/Firefox/Releases/30#Interfaces.2FAPIs.2FDOM