Closed Bug 982616 Opened 10 years ago Closed 10 years ago

Loop Server — Middleware should be tested separately

Categories

(Hello (Loop) :: Server, defect)

Product:
Hello (Loop)
Component:
Server
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: alexis+bugs, Assigned: rhubscher)

References

Details

Attachments

(1 file)

Link to GitHub PR.
55 bytes, text/x-github-pull-request
alexis+bugs
: review+
Details | Review 
Currently, we're testing that middleware behave properly when calling the HTTP endpoint.

This can be a pain if we're using them for more than one route.
The best way to test this is to do it like we've done for checking BID assertions, that is, installing the middleware in a temporary route and testing it's behaving like it should.

Then, we need to test that the middleware is installed in the proper route using the "getMiddleware " utility provided in function_tests.js.
Assignee: nobody → rhubscher
Attached file Link to GitHub PR. — 

        Attachment #8394073 -
        Flags: review?(alexis+bugs)

    
  
Status: NEW → ASSIGNED

    
    

    
  
https://github.com/mozilla-services/loop-server/commit/b3c477742e03b6b8aa94e8bc9fe29d3d0af47c0b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
  

        Attachment #8394073 -
        Flags: review?(alexis+bugs) → review+

    
    

    
  
Closing out the older bugs. The current code is newer than this commit.
Status: RESOLVED → VERIFIED

    
  
QA Contact: jbonacci

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: