FilterNodeD2D1 needs to support DataSourceSurface input surfaces

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla31
x86
macOS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Posted patch v1 (obsolete) — Splinter Review
This is what I had in mind. I haven't tested it yet.
Posted patch v2 (obsolete) — Splinter Review
Fixed to build.
Attachment #8390403 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #8390453 - Flags: review?(bas)
Comment on attachment 8390453 [details] [diff] [review]
v2

Review of attachment 8390453 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawTargetD2D.cpp
@@ +5,5 @@
>  
>  #include <initguid.h>
>  #include "DrawTargetD2D.h"
>  #include "SourceSurfaceD2D.h"
> +#include "SourceSurfaceD2D1.h"

You'll need to include/compile this conditionally I think? Unless we've finally moved everyone to the Windows 8 SDK?
Attachment #8390453 - Flags: review?(bas)
Attachment #8390453 - Flags: review-
Attachment #8390453 - Flags: feedback+
Attachment #8390453 - Attachment is obsolete: true
Attachment #8400855 - Flags: review?(bas)
Attachment #8400855 - Attachment is obsolete: true
Attachment #8400855 - Flags: review?(bas)
Attachment #8401020 - Flags: review?(bas)
Attachment #8401020 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/64119cdee952
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.