982699 - Use super-toast confirmation on adding new Home Panel

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Super-toast will give us the option to take the user to the new panel, or continue whatever they were doing.

Comment 1

[Chenxia Liu [:liuche]]

Ian, any string suggestions for this?

'<New panel name>' has been added | View

Comment 2

[Wesley Johnston (:wesj)]

I worry about this, since we don't really know if there's any data to show at this point. Most of the home panel examples I've seen install the panel before there's actually any data around (and I don't trust panels to fill in content in it arrives while they're showing). Then again, showing this 5 minutes after you create a panel will likely be confusing as well. This will be trickier than it sounds.

Comment 3

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #2)
> I worry about this, since we don't really know if there's any data to show
> at this point. Most of the home panel examples I've seen install the panel
> before there's actually any data around (and I don't trust panels to fill in
> content in it arrives while they're showing). Then again, showing this 5
> minutes after you create a panel will likely be confusing as well. This will
> be trickier than it sounds.

I think this is a separate problem to solve, and goes back to the issue of letting an add-on know when it's been installed. In our demo add-ons, we've just been auto-installing the panel for the user when the add-on is installed, but this is about a user installing the panel from the panel picker activity.

I think part of the solution here will be having sensible empty views for the panels, so that they don't look totally broken, as well as fixing SQLiteBridge to update the cursor when the data changes.

Comment 4

[:Margaret Leibovic]

If this is something we want for 30, we'll need to do it ASAP. However, I don't think this is a really big deal for now, since adding panels from the picker won't be a main use-case for 30, and this is just an enhancement, not a critical issue with the flow.

Comment 5

[Ian Barlow (:ibarlow)]

Yeah, probably not critical for 30

Comment 6

[:Margaret Leibovic]

We removed the "Add panel" item in settings, so this isn't an issue anymore.

There is still the issue of whether or not to take the user to a new panel when it is installed by an add-on, but I think we can leave that up to add-on developers to handle.