Closed Bug 982735 Opened 10 years ago Closed 10 years ago

"Jump to line" menu item in scratchpad doesn't show what the corresponding keyboard shortcut is

Categories

(DevTools Graveyard :: Scratchpad, defect)

Product:
DevTools Graveyard
Component:
Scratchpad
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 31

People

(Reporter: bzbarsky, Assigned: artistskanta)

Details

(Whiteboard: [lang=js][mentor=Benvie])

Attachments

(1 file, 1 obsolete file)

scratch.patch
1.08 KB, patch
bbenvie
: review+
Details | Diff | Splinter Review 
Normally menu items do that, but this one doesn't.
Whiteboard: [good-first-bug][lang=js][mentor=Benvie]
Whiteboard: [good-first-bug][lang=js][mentor=Benvie] → [lang=js][mentor=Benvie]
ignore comment #1, was intended for bug 978742.
Comment 1 is private: false
Attached patch scratch.patch (obsolete) — — Splinter Review 
I fixed this bug, could you have a look at it?
Attachment #8399080 - Flags: review?(bbenvie)
Attached patch scratch.patch — — Splinter Review 
Oops, forgot to add my name.
Attachment #8399080 - Attachment is obsolete: true
Attachment #8399080 - Flags: review?(bbenvie)
Attachment #8399081 - Flags: review?(bbenvie)
Assignee: nobody → artistskanta
Comment on attachment 8399081 [details] [diff] [review]
scratch.patch

Review of attachment 8399081 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks for the patch.
Attachment #8399081 - Flags: review?(bbenvie) → review+
https://hg.mozilla.org/integration/fx-team/rev/0df8eb58bfba
Keywords: checkin-needed
Whiteboard: [lang=js][mentor=Benvie] → [lang=js][mentor=Benvie][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0df8eb58bfba
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js][mentor=Benvie][fixed-in-fx-team] → [lang=js][mentor=Benvie]
Target Milestone: --- → Firefox 31
The following changeset is now in Firefox Nightly:

> 0df8eb58bfba Bug 982735 - Add keyboard shortcut hint for scratchpad jump to line. r=Benvie

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central
Flags: in-testsuite?
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: