982770 - Sidebar border and header styling are broken on Windows 8

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Madhava Enros [:madhava]]

Sidebar splitter/separator and header styling are broken:

Now:    http://cl.ly/image/131r3a2F3X0P
Before: http://cl.ly/image/1d3i1v2O0g0b

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Bisecting Nightlies shows this pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=626d99c084cb&tochange=a98a1d78817f

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I suspect it is from bug 960517.

Comment 3

[Marco Bonardo [:mak]]

The splitter issue is also visible in the Library window.

Comment 4

[:Gijs (he/him)]

(In reply to Madhava Enros [:madhava] from comment #0)
> Sidebar splitter/separator and header styling are broken:
> 
> Now:    http://cl.ly/image/131r3a2F3X0P
> Before: http://cl.ly/image/1d3i1v2O0g0b

Is the 'before' state correct for Windows 8, and/or do we have a design for how this should look somewhere?

Comment 5

[Stephen Horlander [:shorlander]]

(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to Madhava Enros [:madhava] from comment #0)
> > Sidebar splitter/separator and header styling are broken:
> > 
> > Now:    http://cl.ly/image/131r3a2F3X0P
> > Before: http://cl.ly/image/1d3i1v2O0g0b
> 
> Is the 'before' state correct for Windows 8, and/or do we have a design for
> how this should look somewhere?

We have not designed a new look for Windows 8 here. Probably shouldn't be blue but I think we should handle that separately and just use this bug to unbreak them.

Comment 6

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: restore sidebar splitter and header styles

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8394888 [details] [diff] [review]
Patch v1: restore sidebar splitter and header styles

Review of attachment 8394888 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 8

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/57122a5c7406

(I'm assuming this needs uplift and setting flags appropriately, please correct if necessary)

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/57122a5c7406

Comment 10

[Mike de Boer [:mikedeboer]]

Comment on attachment 8394888 [details] [diff] [review]
Patch v1: restore sidebar splitter and header styles

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis, bug 960517.
User impact if declined: the vertical splitters (which sidebars have) look big and clunky on Vista, Win 7 and Win 8. This restores the 'old' style.
Testing completed (on m-c, etc.): landed on m-c and stuck.
Risk to taking this patch (and alternatives if risky): minor.
String or IDL/UUID changes made by this patch: n/a

Comment 11

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a702c459a7f9

https://hg.mozilla.org/releases/mozilla-beta/rev/23bda6a51bd2

Comment 12

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.3; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0		
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0		

Verified as fixed on:
- latest Nightly (build ID: 20140327030203)
- latest Aurora (build ID: 20140327004002)
- Firefox 29 beta 3 (build ID: 20140327113732)