982806 - Partner repack changes for web.de, gmx, and mail.com (Firefox 28)

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: ff28.diff

Diff attached

Comment 1

[Mike Kaply [:mkaply]]

Attachment: ff28.diff

Comment 2

[Mike Kaply [:mkaply]]

AMO requested specific fixes, and those are in this release. Otherwise, there isn't a lot of change.

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 8390009 [details] [diff] [review]
ff28.diff

Not sure if I need review here, but requesting just in case.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8390009 [details] [diff] [review]
ff28.diff

Review of attachment 8390009 [details] [diff] [review]:
-----------------------------------------------------------------

Please land this ASAP, we have a respin coming soon.

In the future, landing no later than Monday afternoon (8 days before ship) is what you should shoot for -- we go to build on final releases on that Monday these days.

Comment 5

[Mike Kaply [:mkaply]]

> Please land this ASAP, we have a respin coming soon.

I've landed this

> In the future, landing no later than Monday afternoon (8 days before ship) is what you should shoot for -- we go to build on final releases on that Monday these days.

Yeah, my apologies. I didn't realize FF28 was coming so fast.

Comment 6

[Mike Kaply [:mkaply]]

I just found a stupid typo in my push.

Any chance if I push it it will make 28 or is it too late?

It's not a huge issue, but would be nice to have (breaks disable/reenable).

Comment 7

[Mike Kaply [:mkaply]]

Attachment: nsg.diff

This is a diff of the problem.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8390862 [details] [diff] [review]
nsg.diff

*stamp*

Comment 9

[Mike Kaply [:mkaply]]

So I majorly screwed up and forgot to checkin the new file associated with our changes.

So our partner builds are DOA.

I have no idea if this can be remedied easily on the build end.

Changeset is

https://hg.mozilla.org/build/partner-repacks/rev/9a8324d293ba

I'm really sorry for the screw up. I'm working on changing my/our process to make sure this doesn't happen again.

Comment 10

[Rail Aliiev [:rail]]

Do we need to regenerate the repacks fir this change? Looks like it was landed after we started 28.0 build2.

Comment 11

[Mike Kaply [:mkaply]]

(In reply to Rail Aliiev [:rail] from comment #10)
> Do we need to regenerate the repacks fir this change? Looks like it was
> landed after we started 28.0 build2.

Unfortunately yes. We didn't catch this until after the repacks.

We're looking at revamping our process so this would have been caught much earlier.

If partner code is in, would repacks get built as part of the normal beta build process?

Comment 12

[Rail Aliiev [:rail]]

gmx, mail.com and web.de repacks are regenerated and uploaded to http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/28.0-candidates/build2/partner-repacks/

(In reply to Mike Kaply (:mkaply) from comment #11)
> If partner code is in, would repacks get built as part of the normal beta
> build process?

Yes, we use the same partner repack configs for releases and betas.