Closed Bug 982844 Opened 6 years ago Closed 6 years ago
[B2G][Contacts][Facebook]Facebook contacts cannot be re-imported after being manually deleted from device contacts list
If the user imports all contact from facebook, then deletes a contact from it's contact details page, they will not be able to re-import that profile from facebook. The contact can be selected in the checklist of FB contacts, but will not be updated. User will see a message: "no friends updated." Repro Steps: 1) Updated Buri to BuildID: 20140312004001 2) Launch Contacts app. 3) Tap on settings > Facebook 'sync friends' button. Sign into a profile. 4) Tap 'Select All' then 'Import'. 5) Return to contacts list and locate imported contact. 6) Manually delete contact. 7) Return to list of facebook contacts and re-import the deleted contact. Actual: Facebook contact is not imported. Expected: Facebook contact can be re-imported after being manually deleted. Environmental Variables: Device: Buri v1.3 Moz RIL BuildID: 20140312004001 Gaia: df157ce3a3f841850a1cce8f057f8e7f547fb9f8 Gecko: c629684b0eae Version: 28.0 Firmware Version: v1.2-device.cfg Notes: Repro frequency: 100% See attached: logcat
Does this reproduce on 1.1?
Hi rkuhlman, although I have had some issues with the builds today :-( , would you be so kind to retry it using today's 1.3 build? I have checked that it works as expected in 1.3 (Gecko-ccc26f7.Gaia-6194def) and in 1.2 (Gecko-04ef95a.Gaia-539a25e) :) Thanks!
with latest M-C I'm getting the following error while deleting a FB Contact Content JS ERROR at app://communications.gaiamobile.org/contacts/js/fb/fb_data.js:292 in errorRemove: FB Data: Error while removing 100000466370089 : ConstraintError E/GeckoConsole( 477): Content JS ERROR at app://communications.gaiamobile.org/contacts/js/views/form.js:545 in errorDelete: Error removing the contact
blocking-b2g: --- → 1.4?
I am no longer able to repro the issue in 1.3 or 1.1. Seems to be fixed. Environmental Variables: Device: Buri v1.1 Moz RIL BuildID: 20140306041201 Gaia: 44a2ddf63373f8e95c784faf4ed4d60081699c61 Gecko: 1421a6b7fc51 Version: 18.0 Firmware Version: v1.2-device.cfg Environmental Variables: Device: Buri v1.3 Moz RIL BuildID: 20140313004002 Gaia: 6194def5ceed3f4b9bc9de0ea2c11661cd439a27 Gecko: 9368fd13bfa6 Version: 28.0 Firmware Version: v1.2-device.cfg
I am still able to repro the issue on today's build. However, the steps have changed. It appears that the problem occurs when visiting the FB friends list for the third time or later. I am able to repro the issue in several different ways, and the only shared details are that the FB list must be visited three times, and the contact must be manually deleted. Here are three sets of steps that allowed me to repro the issue: 1) Download all FB contacts. 2) Delete Contact A. 3) Download Contact A again. 4) Delete Contact A again. 5) Attempt to download Contact A. (Error occurs) 1) Download some FB contacts. 2) Download all remaining FB contacts. 3) Delete Contact A. 4) Attempt to download Contact A. (Error occurs) 1) Download Contact A. 2) Delete Contact A. 3) Download Contact A again. 4) Delete Contact A again. 5) Attempt to download Contact A. (Error occurs)
As per my investigations this is a datastore issue. The issue can be reproduced as follows insert a record on a datastore with a custom id delete such a record from the datastore insert the same record another with the same custom id delete one more time the record. Then you will get a 'ConstraintError' Note, that the cycle, insert, delete, insert, might need to be done several times in order to reproduce it.
I don't think the problem is in the datastore. This mochitest does this operation 100 times and no errors are shown. are you sure that you wait for the promise callback before doing the next operation?
On the build marked "Last Blocked", Facebook contacts can not be fully deleted, which blocks checking of this issue. Following the string of dupes about imported Facebook contacts not being able to be deleted, earlier testing of this issue seems to be blocked by Bug 931711. Nightly Regression Window: Last Blocked Environmental Variables: Device: Buri BuildID: 20140117004005 Gaia: a81ccdc53e45a6adeaae423e104e91bcc1e12b0e Gecko: 2c033140eff4 Version: 28.0a2 Base Image: V1.2-device.cfg First Verified Broken Environmental Variables: Device: Buri BuildID: 20140118004001 Gaia: 50d6487d4d15efda942c934570e6fdfb91f6fe2e Gecko: 9561abd10c52 Version: 28.0a2 Base Image: V1.2-device.cfg Blocked Gaia/First Broken Gecko: Issue is blocked. Gaia: a81ccdc53e45a6adeaae423e104e91bcc1e12b0e Gecko: 9561abd10c52 First Broken Gaia/Blocked Gecko: Issue DOES reproduce. Gaia: 50d6487d4d15efda942c934570e6fdfb91f6fe2e Gecko: 2c033140eff4 Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/a81ccdc53e45a6adeaae423e104e91bcc1e12b0e...50d6487d4d15efda942c934570e6fdfb91f6fe2e If there is nothing of use in the provided pushlog, I could also find the window between the last verified working build and the first blocked build if requested.
It's a gecko bug. The auto increment key for the revision object store doesn't work and an existing key is reused. This causes a ConstrainError. I am able to reproduce this issue 100% of the times just on a real device: mochitests, oop mochitests, b2g-desktop they work. Still debugging.
Assignee: jmcf → amarchesini
triage: 1.4+ regression
blocking-b2g: 1.4? → 1.4+
Component: Gaia::Contacts → DOM: Device Interfaces
Product: Firefox OS → Core
Version: unspecified → 30 Branch
Andrea and I spoke about this earlier and he's still debugging here.
It seems that patch 1 for bug bug 970303 fixes this issue. If someone can confirm it, we can mark this bug as duplicate.
Jason, can QA help confirm Andreas theory above?
QA Contact: rkunkel → rkuhlman
(In reply to Johnny Stenback (:jst, firstname.lastname@example.org) from comment #15) > Jason, can QA help confirm Andreas theory above? Sure - we can retest this post landing of bug 970303.
For the record, bug 970303 has a reviewed patch but can't land until its dependent bug 981938 is done. The current ETA for that (from chatting with Ted on irc) is later this week.
Still waiting on dependencies landing. Ted has a re-worked patch and Ben is likely able to do the review early this week.
Should be fixed now. Marking qawanted to retest.
I cannot reproduce this issue using the steps from comment 6 on the latest Buri v1.4 mozRIL BuildID: 20140414000201. Gaia: 8dff633372022723e2ebad17fe3c826436b3b258 Gecko: bc14179fc49c Version: 30.0a2 Firmware Version: v1.2-device.cfg
Marking fixed per landing of the dependency.
tested and working 1.5 Gecko fa7c5ad Gaia 7c73c66
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.