982893 - attempt to avoid initializing Weave.Status from under updateUI doesn't work

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

There's code in browser-syncui's _loginFailed that checks service.ready before referencing Weave.Status, to try to avoid importing some Sync modules on startup.

However, the code in _needsSetup references Weave.Status unconditionally, so those modules get loaded anyways (_needsSetup and _loginFailed are both called by updateUI, which is called on window open via initUI).

The patch in bug 966342 that checked the user state also avoided initializing the service if it wasn't already, by checking service.ready before referencing Weave.Service.identity._signedInUser. But we can access _signedInUser via Weave.Status._authManager instead (which we are loading anyways), to avoid the issue of the menu being incorrect before Sync is initialized.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

* don't try to avoid loading Weave.Status modules on window open 
 * access the authManager via Weave.Status instead of Weave.Service, since Weave.Status will already be initialized in almost all cases.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: tweaked patch

Fixed the comment.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: tweaked patch

Fixed the comment as discussed IRL.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/fx-team/rev/8260554d3422

This is a trunk-only bug (relevant changes included in bug 966342's aurora patch)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8260554d3422