982944 - Scriptish GM_* function stops working

Status: RESOLVED WONTFIX

(Firefox :: Extension Compatibility, defect)

Description

[Alice0775 White]

Attachment: sample script

Steps To Reproduce:
1. Install Scriptish 0.1.11 https://addons.mozilla.org/en-US/firefox/addon/scriptish/
2. Restart
3. Install script using GM_* function (attached)
4. Open web page

Actual Results:
In Error Consle,
Error: Scriptish access violation: unsafeWindow cannot call: GM_getValue

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0d472d6e645
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140305200107
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8adacb553312
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140305201607
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c0d472d6e645&tochange=8adacb553312

Triggered by:
8adacb553312	Bobby Holley — Bug 960108 - Ignore saved frame chains and contexts in JS::DescribeStack. r=bz

Comment 1

[Alice0775 White]

Attachment: scriptish-0.1.11-fx+sm - コピー.xpi ( modified version )

Add logging to \modules\api.js  GM_apiLeakCheck

The problem is that return value of Components.stack.filename is different between Nightly30.0a1 and Aurora29.0a2

Each "chrome://..." and "jar:file:///..."

In Aurora29.0a2:

resource://scriptish/api.js
GM_apiLeakCheck

resource://scriptish/api.js
GM_getValue

chrome://scriptish/content/scriptish.js -> file:///C:/Users/fuku/AppData/Roaming/Mozilla/Firefox/Profiles/u0msmutr.Scriptish/scriptish_scripts/adjustcolor@byshakku/[e-mail]
null

null
null




In Nightly30.0a1:

resource://scriptish/api.js
GM_apiLeakCheck

resource://scriptish/api.js
GM_getValue

chrome://scriptish/content/scriptish.js -> file:///C:/Users/fuku/AppData/Roaming/Mozilla/Firefox/Profiles/u0msmutr.Scriptish/scriptish_scripts/adjustcolor@byshakku/[e-mail]
null

resource://scriptish/utils/Scriptish_evalInSandbox.js
Scriptish_evalInSandbox

resource://scriptish/utils/Scriptish_injectScripts.js
Scriptish_injectScripts

jar:file:///C:/Users/user/AppData/Roaming/Mozilla/Firefox/Profiles/u0msmutr.Scriptish/extensions/[e-mail]!/components/scriptish.js
ScriptishService.prototype.docReady/</<

Scriptish access violation: unsafeWindow cannot call: GM_getValue

null
null

Comment 2

[Alice0775 White]

And depth of stack is different  between Nightly30.0a1 and Aurora29.0a2

Each "4" and "7"

Comment 3

[Alice0775 White]

Sorry,
Each "7" and "4"

Comment 4

[Bobby Holley (:bholley)]

Anthony/Alex, I recently changed the behavior of Components.stack to ignore saved frame chain boundaries (event dispatch, callback invocation, etc) and display all frames. Presumably this breaks the GM stack introspection? Is that something that can be easily fixed?

Comment 5

[Alexander Sturm]

Yeah, this can be easily fixed in Scriptish by adding a few more files to the stack whitelist (I left a comment on their bug tracker describing which ones). Greasemonkey itself doesn't need any changes, as the slightly less restrictive whitelist already handled this.

Comment 6

[Benjamin Kerensa [:bkerensa]]

I don't think were going to track this since its being addressed upstream and low impact for our users.

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Handled here https://github.com/scriptish/scriptish/issues/203

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Mass-closing old Extension Compatibility bugs that relate to legacy add-ons or NPAPI plug-ins. If you think this bug is still valid, please reopen or comment.

Sorry for the bug spam, and happy Friday!