Closed Bug 983000 Opened 11 years ago Closed 11 years ago

Intermittent test_ping_aboutnetworking.js | test failed (with xpcshell return code: 0), see following log | -1 != -1 - See following stack

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Version:
29 Branch
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32
Tracking Flags:
Tracking Status
firefox28 --- unaffected
firefox29 --- unaffected
firefox30 --- wontfix
firefox31 --- fixed
firefox32 --- fixed
firefox-esr24 --- unaffected
b2g-v1.4 --- wontfix
b2g-v2.0 --- fixed

People

(Reporter: KWierso, Assigned: valentin)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Intermittent test_ping_aboutnetworking.js
2.26 KB, patch
mcmanus
: review+
Details | Diff | Splinter Review
Second fix
2.82 KB, patch
mcmanus
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=36012850&tree=Fx-Team slave: talos-r4-snow-016 11:38:04 INFO - Retrying tests that failed when run in parallel. 11:38:04 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | running test ... 11:38:04 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | test failed (with xpcshell return code: 0), see following log: 11:38:04 INFO - >>>>>>> 11:38:04 INFO - [4037] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/slave/fx-team-osx64-d-00000000000000/build/toolkit/crashreporter/nsExceptionHandler.cpp, line 2107 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (2) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test MAIN run_test finished (2) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | running event loop 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (2) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (3) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (3) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (3) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (4) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (4) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (4) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (5) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (5) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (5) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test pending (6) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (6) 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 44] true == true 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (5) 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 58] 0 != -1 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 59] 54283 == 54283 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 60] true == 1 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (4) 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 44] true == true 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (3) 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 58] 0 != -1 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 59] 54283 == 54283 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 60] true == 1 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (2) 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 44] true == true 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (1) 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | exiting test 11:38:04 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | -1 != -1 - See following stack: 11:38:04 INFO - JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js :: run_test/</< :: line 58 11:38:04 INFO - JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/head.js :: _do_main :: line 177 11:38:04 INFO - JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/head.js :: _execute_test :: line 378 11:38:04 INFO - JS frame :: -e :: <TOP_LEVEL> :: line 1 11:38:04 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | exiting test 11:38:04 INFO - System JS : ERROR (null):0 - uncaught exception: 2147500036 11:38:04 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | [run_test/</< : 44] true == true 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | test finished (0) 11:38:04 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js | -1 != -1 - See following stack: 11:38:04 INFO - JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_ping_aboutnetworking.js :: run_test/</< :: line 58 11:38:04 INFO - JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/head.js :: _do_main :: line 177 11:38:04 INFO - JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/head.js :: _execute_test :: line 378 11:38:04 INFO - JS frame :: -e :: <TOP_LEVEL> :: line 1 11:38:04 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 11:38:04 INFO - TEST-INFO | (xpcshell/head.js) | exiting test 11:38:04 INFO - System JS : ERROR (null):0 - uncaught exception: 2147500036 11:38:04 INFO - [4037] WARNING: '!compMgr', file /builds/slave/fx-team-osx64-d-00000000000000/build/xpcom/glue/nsComponentManagerUtils.cpp, line 59 11:38:04 INFO - [4037] WARNING: OOPDeinit() without successful OOPInit(): file /builds/slave/fx-team-osx64-d-00000000000000/build/toolkit/crashreporter/nsExceptionHandler.cpp, line 2551 11:38:04 INFO - [4037] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/slave/fx-team-osx64-d-00000000000000/build/xpcom/base/nsTraceRefcnt.cpp, line 142 11:38:04 INFO - [4037] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/slave/fx-team-osx64-d-00000000000000/build/xpcom/base/nsTraceRefcnt.cpp, line 142 11:38:04 INFO - nsStringStats 11:38:04 INFO - => mAllocCount: 2265 11:38:04 INFO - => mReallocCount: 231 11:38:04 INFO - => mFreeCount: 2265 11:38:04 INFO - => mShareCount: 8476 11:38:04 INFO - => mAdoptCount: 52 11:38:04 INFO - => mAdoptFreeCount: 52 11:38:04 INFO - => Process ID: 4037, Thread ID: 140735091064000 11:38:04 INFO - <<<<<<< 11:38:04 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | running test ... 11:38:06 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | test passed (time: 2372.672ms) 11:38:06 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/search/tests/xpcshell/test_serialize_file.js | running test ... 11:38:07 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/search/tests/xpcshell/test_serialize_file.js | test passed (time: 994.443ms) 11:38:07 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/devtools/server/tests/unit/test_trace_actor-07.js | running test ... 11:38:08 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/devtools/server/tests/unit/test_trace_actor-07.js | test passed (time: 467.063ms) 11:38:08 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_base_updater/marStageSuccessComplete.js | running test ... 11:38:09 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_base_updater/marStageSuccessComplete.js | test passed (time: 1261.719ms) 11:38:09 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_base_updater/marStageSuccessPartial.js | running test ... 11:38:10 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_base_updater/marStageSuccessPartial.js | test passed (time: 1176.748ms) 11:38:10 INFO - INFO | Result summary: 11:38:10 INFO - INFO | Passed: 1871 11:38:10 WARNING - INFO | Failed: 1 11:38:10 WARNING - One or more unittests failed. 11:38:10 INFO - INFO | Todo: 4 11:38:10 INFO - INFO | Retried: 6 11:38:10 ERROR - Return code: 1
Assignee: nobody → valentin.gosu
Blocks: 904594
Comment on attachment 8390444 [details] [diff] [review] Intermittent test_ping_aboutnetworking.js The intermittent failure was due to the fact that both requestConnection and requestSockets were issued at the same time, but requestSockets actually finished before a connection was actually established. This patch calls requestSockets only after successfully establishing a connection. try run: https://tbpl.mozilla.org/?tree=Try&rev=8283dc711f7e
Attachment #8390444 - Flags: review?(mcmanus)
Attachment #8390444 - Flags: review?(mcmanus) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b84220fd962 Also, I tweaked your commit message to better reflect what the patch is doing. Please keep that in mind for the future :) https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment
Flags: in-testsuite+
Keywords: checkin-needed
Thanks!
https://hg.mozilla.org/mozilla-central/rev/5b84220fd962
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
System JS : ERROR (null):0 - uncaught exception: 2147500036 [...] TEST-INFO | (xpcshell/head.js) | test finished (-1) TEST-INFO | test_ping_aboutnetworking.js | "[{"active":true,"host":"","port":0,"received":0,"sent":0,"tcp":true}]" TEST-UNEXPECTED-FAIL | test_ping_aboutnetworking.js | -1 != -1 - See following stack: Apparently there is an entry for the socket, but all of the fields are empty. Investigating...
Attached patch Second fix — — Splinter Review
The serverSocket is not declared globally anymore. Not calling close() since that is done in the server socket destructor. https://tbpl.mozilla.org/?tree=Try&rev=44d6d486b382
Attachment #8416194 - Flags: review?(mcmanus)
Comment on attachment 8416194 [details] [diff] [review] Second fix Review of attachment 8416194 [details] [diff] [review]: ----------------------------------------------------------------- yeah for gc
Attachment #8416194 - Flags: review?(mcmanus) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e8eceeb7fa65
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
status-b2g-v1.4: --- → affected
status-b2g-v2.0: --- → fixed
status-firefox30: fixed → affected
status-firefox31: --- → affected
status-firefox32: --- → fixed
Target Milestone: mozilla30 → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: