Closed
Bug 983039
Opened 11 years ago
Closed 11 years ago
[Media encoder] Support YV12 GrallocImage in OMXVideoEncoder on B2G.
Categories
(Core :: Audio/Video: Recording, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: jhlin, Assigned: jhlin)
Details
Attachments
(1 file, 2 obsolete files)
6.22 KB,
patch
|
jhlin
:
review+
|
Details | Diff | Splinter Review |
Currently OMXVideoDecoder only accepts GrallocImage in NV21 format. But since bug 965440, decoders start to generate GrallocImage in YV12 format for output. So YV12 GrallocImage support in OMXVideoEncoder is necessary to make transcoding work.
Assignee | ||
Comment 1•11 years ago
|
||
Add YV12 input support. Also extract graphic buffer handling code to subroutine to improve readability. :)
Attachment #8390376 -
Flags: review?(roc)
Assignee | ||
Comment 2•11 years ago
|
||
Upload correct patch.
Attachment #8390376 -
Attachment is obsolete: true
Attachment #8390376 -
Flags: review?(roc)
Attachment #8390378 -
Flags: review?(roc)
Attachment #8390378 -
Flags: review?(roc) → review+
Assignee | ||
Comment 3•11 years ago
|
||
- Update commit message & carry r+ from roc.
- Try result: https://tbpl.mozilla.org/?tree=Try&rev=c47bf4d7cf67
Attachment #8390378 -
Attachment is obsolete: true
Attachment #8391088 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•