983045 - Change the word "outstanding" in the request nagger emails to "overdue"

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

My "Your Outstanding Requests" email today (received a few minutes ago) is missing some of my outstanding requests -- in particular, all of those from bug 966166.

Not sure if this is a server problem (related to other recent issues) or a code problem, but starting with the latter.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: today's email

Compare to https://bugzilla.mozilla.org/request.cgi?action=queue&type=all&requestee=dbaron%40dbaron.org&group=requestee and note the conspicuous absence of bug 966166 from the review section.

Comment 2

[:glob ✱]

main point of request nagger is to notify you of _outstanding_ requests, which can be different from _current_ requests.  requests older than a per-product period are included in the emails it generates.

bug 966166 is part of the core product, where this duration is set to 1 day, which is the minimum value (the default setting is 7 days).

as those flags were set fewer than 24 hours before the nag email was generated, they will not be listed in the email.  if they aren't actioned, they should appear in tonight's email.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sounds like the header of the email should explain that better.  I'd interpret "outstanding" as the same as "pending" or "unanswered".

Comment 4

[:glob ✱]

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-7) from comment #3)
> Sounds like the header of the email should explain that better.  I'd
> interpret "outstanding" as the same as "pending" or "unanswered".

good point.

:blassey - do you have any objections to changing "outstanding" to "overdue"?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Byron Jones ‹:glob› from comment #4)
> (In reply to David Baron [:dbaron] (needinfo? me) (UTC-7) from comment #3)
> > Sounds like the header of the email should explain that better.  I'd
> > interpret "outstanding" as the same as "pending" or "unanswered".
> 
> good point.
> 
> :blassey - do you have any objections to changing "outstanding" to "overdue"?

nope, no objection.

Comment 6

[David Lawrence [:dkl]]

Attachment: 983045_1.patch

Comment 7

[:glob ✱]

Comment on attachment 8392819 [details] [diff] [review]
983045_1.patch

Review of attachment 8392819 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 8

[David Lawrence [:dkl]]

Counting objects: 43, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (19/19), done.
Writing objects: 100% (23/23), 2.76 KiB, done.
Total 23 (delta 11), reused 0 (delta 0)
To ssh://[e-mail]/webtools/bmo/bugzilla.git
   80c784c..076af7d  4.2 -> 4.2