Closed Bug 983121 Opened 7 years ago Closed 7 years ago

Properly cleanup tab actors when disconnecting

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 30

People

(Reporter: past, Assigned: past)

References

Details

Attachments

(1 file)

Properly cleanup the tab actors when disconnecting
1.50 KB, patch
rcampbell
: review+
Details | Diff | Splinter Review 
Bug 937172 refactored the tab actors for e10s, but the cleanup is only performed on exit(). We should do it on disconnect() as well, to make sure we don't get any leaks when the tab actor gets destroyed from an abrupt connection teardown.
Assignee: nobody → past
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8390464 [details] [diff] [review]
Properly cleanup the tab actors when disconnecting

Review of attachment 8390464 [details] [diff] [review]:
-----------------------------------------------------------------

yes.
Attachment #8390464 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/d97f7e8227c1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
QA Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.