Closed
Bug 983121
Opened 6 years ago
Closed 6 years ago
Properly cleanup tab actors when disconnecting
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
P3
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Bug 937172 refactored the tab actors for e10s, but the cleanup is only performed on exit(). We should do it on disconnect() as well, to make sure we don't get any leaks when the tab actor gets destroyed from an abrupt connection teardown.
|
Assignee | |
Comment 1•6 years ago
|
||
Simple fix. Try: https://tbpl.mozilla.org/?tree=Try&rev=d560c7c60a25
Attachment #8390464 -
Flags: review?(rcampbell)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P3
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8390464 [details] [diff] [review] Properly cleanup the tab actors when disconnecting Review of attachment 8390464 [details] [diff] [review]: ----------------------------------------------------------------- yes.
Attachment #8390464 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d97f7e8227c1
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d97f7e8227c1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
|
||
Updated•6 years ago
|
QA Whiteboard: [qa-]
|
||
Updated•2 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•