983204 - RSTP broken after decode tasks refactoring

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The RTSP on B2G is broken since the decode tasks refactoring in bug 983408.

The problem seems to be that we used to call RtspOmxReader::OnDecodeThreadStart() which play()ed the OMXDecoder, but now that the state machine/reader assumes the reader is active at startup and doesn't call SetActive() so the OMX decoder is never started.

Comment 1

[Ethan Tseng [:ethan]]

(In reply to Chris Pearce (:cpearce) from comment #0)
> The RTSP on B2G is broken since the decode tasks refactoring in bug 983408.
Chris, thanks for firing this bug.
The bug number should be bug 973408. :)

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8390926 [details] [diff] [review]
Patch

Review of attachment 8390926 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for your help, it looks good. :-)

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d42a36615c7e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/902647372519 for build bustage: 
https://tbpl.mozilla.org/php/getParsedLog.php?id=36112123&tree=Mozilla-Inbound 
https://tbpl.mozilla.org/php/getParsedLog.php?id=36111992&tree=Mozilla-Inbound

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Landed fixed build:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8339097d3060

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8339097d3060