Closed Bug 983204 Opened 8 years ago Closed 8 years ago

RSTP broken after decode tasks refactoring

Categories

(Core :: Audio/Video, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(1 file)

The RTSP on B2G is broken since the decode tasks refactoring in bug 983408.

The problem seems to be that we used to call RtspOmxReader::OnDecodeThreadStart() which play()ed the OMXDecoder, but now that the state machine/reader assumes the reader is active at startup and doesn't call SetActive() so the OMX decoder is never started.
(In reply to Chris Pearce (:cpearce) from comment #0)
> The RTSP on B2G is broken since the decode tasks refactoring in bug 983408.
Chris, thanks for firing this bug.
The bug number should be bug 973408. :)
Attached patch PatchSplinter Review
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #8390926 - Flags: review?(vchang)
Comment on attachment 8390926 [details] [diff] [review]
Patch

Review of attachment 8390926 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for your help, it looks good. :-)
Attachment #8390926 - Flags: review?(vchang) → review+
https://hg.mozilla.org/mozilla-central/rev/8339097d3060
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.