Closed
Bug 983204
Opened 9 years ago
Closed 9 years ago
RSTP broken after decode tasks refactoring
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: cpearce, Assigned: cpearce)
Details
Attachments
(1 file)
2.21 KB,
patch
|
vchang
:
review+
|
Details | Diff | Splinter Review |
The RTSP on B2G is broken since the decode tasks refactoring in bug 983408. The problem seems to be that we used to call RtspOmxReader::OnDecodeThreadStart() which play()ed the OMXDecoder, but now that the state machine/reader assumes the reader is active at startup and doesn't call SetActive() so the OMX decoder is never started.
Comment 1•9 years ago
|
||
(In reply to Chris Pearce (:cpearce) from comment #0) > The RTSP on B2G is broken since the decode tasks refactoring in bug 983408. Chris, thanks for firing this bug. The bug number should be bug 973408. :)
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8390926 [details] [diff] [review] Patch Review of attachment 8390926 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for your help, it looks good. :-)
Attachment #8390926 -
Flags: review?(vchang) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d42a36615c7e
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/902647372519 for build bustage: https://tbpl.mozilla.org/php/getParsedLog.php?id=36112123&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=36111992&tree=Mozilla-Inbound
Assignee | ||
Comment 6•9 years ago
|
||
Landed fixed build: https://hg.mozilla.org/integration/mozilla-inbound/rev/8339097d3060
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8339097d3060
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•