983296 - [netmonitor] align numeric values at comma position

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

In the netmonitor's list view, the size of the requested files are centered. In the pie charts, sizes are left aligned. It would be pretty if these values could be aligned at the comma.

Comment 1

[Julian Descottes [:jdescottes]]

It's now aligned to the left in both views.
But I agree that aligning to the right (+ switching optionally to monospace?) would make the columns more readable.
FWIW, Chrome devtools aligns numerical values to the right.

Setting myself as mentor if anyone wants to give it a shot.

Comment 2

[Lorenz A]

Attachment: Bug 983296 - Right align values in numerical columns in netmonitor. r=jdescottes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3c3d5459813
https://hg.mozilla.org/integration/autoland/rev/972dfb7c8699
Right align values in numerical columns in netmonitor. r=jdescottes,devtools-reviewers

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/972dfb7c8699