983414 - Sync success doorhanger copy should accurately reflect time delay in initial sync

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[John Gruen [:jgruen]]

current: 

<!ENTITY syncStartPanel.heading "&brandShortName; is now syncing">
<!ENTITY syncStartPanel.subTitle "You can manage &syncBrand.shortName.label; in Options.">
<!ENTITY syncStartPanel.subTitleUnix "You can manage &syncBrand.shortName.label; in Preferences.">

expected:

title - Sync enabled
subtitle - &brandShortName; will begin syncing momentarily.

Comment 1

[John Gruen [:jgruen]]

Attachment: 0001-Bug-983414-fix-sync-success-copy-and-formatting.-r-m.patch

Thanks Mark!

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8390889 [details] [diff] [review]
0001-Bug-983414-fix-sync-success-copy-and-formatting.-r-m.patch

Review of attachment 8390889 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.xul
@@ +404,5 @@
>          <image class="sync-panel-icon"/>
>          <vbox class="sync-panel-inner">
>            <description id="sync-start-panel-title"
> +                       value="&syncStartPanel2.heading;"/>
> +          <description id="sync-start-panel-subtitle" 

trailing whitespace

Comment 3

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/7d63f2bf9042

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d63f2bf9042