983426 - Run uploaded icons through PNG lossless optimizer

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect, P2)

Description

[Mathieu Pillard [:mat]]

We should run the icons we host through a lossless optimizer like pngcrush to get smaller file sizes. We already resize them in a task, so it could be done asynchronously pretty easily.

We won't get huge wins - probably less than 10%, every byte counts!

Comment 1

[Doug Turner (:dougt)]

What was your command line.  There are lots of options.  Some don't make a difference.

Comment 2

[Mathieu Pillard [:mat]]

I had tested with optipng with -o7. 

Here are my results for a new attempt at crushing all 35 64x64 icons from /fireplace/search/featured/ API endpoint for region "us" (we don't necessarily load them all by default, especially on mobile, but this was just a quick and dirty test):

Originals: 328K
Using pngcrush -rem alla -brute -reduce: 292K
Using optipng -o7: 316K

Comment 3

[Mathieu Pillard [:mat]]

Giving bug to :nearlyfreeapps since he mentioned on IRC he wanted to take a look.

Note: it would be interesting to do the same thing for previews as well, but let's keep things simple and start with icons first.

Comment 4

[Glenn Randers-Pehrson]

(In reply to Mathieu Pillard [:mat] from comment #2)

> Here are my results for a new attempt at crushing all 35 64x64 icons 
> Using pngcrush -rem alla -brute -reduce: 292K
> Using optipng -o7: 316K

Be sure to use the current release of pngcrush (1.7.73); there have
been problems with the "-reduce" option in earlier versions.

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/ac35b14438914f27026bf27e71afdac6e9c87bf8

STR:
- Upload an app, make icon submission and edit still work and that the icon displayed in consumer pages and developer pages once the app is approved is not altered.

(we'll verify that the size reduction is working properly ourselves)

Comment 6

[Iulian Timis]

I have submitted a new app with an icon, and then changed the icon twice in the Edit Listing page.
In consumer pages, the icon displayed is the second uploaded icon, and not the actual icon.
Please see screencast http://screencast.com/t/FGGkpZhIZ

Comment 7

[Mathieu Pillard [:mat]]

I see yet another icon (a red car) when I go to your app now : https://marketplace.allizom.org/app/test-app-icon ; does that mean that it eventually updated ?

Comment 8

[Iulian Timis]

No, that's the last icon I have uploaded, but this is what I see in consumer pages http://screencast.com/t/iATfmIEMw

Comment 9

[Mathieu Pillard [:mat]]

Closing since the icon eventually appeared. Stage and dev have both been having issues which we believe would be solved by bug 987927.

Comment 10

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/ on FF29 (Win 7).
Postfix screencast http://screencast.com/t/ZzSXwsZt9
Closing bug.