Closed
Bug 983435
Opened 10 years ago
Closed 10 years ago
Refine built-in subscribe menu
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
2.58 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
While working on bug 977200, I found that our built-in flow doesn't match the mock-ups specified in that bug. I think there are some changes we should make to the product so that the flow with and without the add-on is the same, except with the add-on you get the page action item and the "Firefox homepage" provider option. Points I think we need to address: * Add "Subscribe to page with" title to prompt with subscription services * Add a title to the prompt that appears when there are multiple feeds on the page. This isn't part of the mock-ups, but I think we should do it for consistency. I propose something like "Choose feed".
Flags: needinfo?(ibarlow)
Comment 1•10 years ago
|
||
(In reply to :Margaret Leibovic from comment #0) Gah, I lost this in a pile of pinned tabs, sorry. I agree with both of your suggestions, Margaret, and your proposed strings seem fine to me.
Flags: needinfo?(ibarlow)
Assignee | ||
Comment 2•10 years ago
|
||
This patch just adds titles to our existing subscribe prompts. I'll needinfo ibarlow for feedback on the strings.
Attachment #8400223 -
Flags: review?(wjohnston)
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to :Margaret Leibovic from comment #2) > Created attachment 8400223 [details] [diff] [review] > Add titles to subscribe prompts > > This patch just adds titles to our existing subscribe prompts. I'll needinfo > ibarlow for feedback on the strings. Oh wait, he already approved these in comment 1 :)
Comment 4•10 years ago
|
||
Comment on attachment 8400223 [details] [diff] [review] Add titles to subscribe prompts Review of attachment 8400223 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/locales/en-US/chrome/browser.properties @@ +331,5 @@ > browser.menu.context.tel = Phone > browser.menu.context.mailto = Mail > + > +# "Subscribe to page" prompts created in FeedHandler.js > +feedHandler.chooseFeed=Choose feed I wonder if users even know what the word "feed" means. But if UX is ok... :) @@ +332,5 @@ > browser.menu.context.mailto = Mail > + > +# "Subscribe to page" prompts created in FeedHandler.js > +feedHandler.chooseFeed=Choose feed > +feedHandler.subscribeToPageWith=Subscribe to page with I would probably vote for just "Subscribe with".
Attachment #8400223 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Let's double check with ibarlow. For the "Subscribe to page with" string, we'll want to be consistent with my feeds add-on (right now that uses "Subscribe to page with").
Flags: needinfo?(ibarlow)
Comment 6•10 years ago
|
||
Is the question here about whether we can simplify the context menu title to just read "Subscribe with"? If so, that sounds fine to me.
Flags: needinfo?(ibarlow)
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Ian Barlow (:ibarlow) from comment #6) > Is the question here about whether we can simplify the context menu title to > just read "Subscribe with"? > > If so, that sounds fine to me. I updated my patch to match this suggestion, and I also updated the home feeds add-on: https://github.com/leibovic/fennec_rss/blob/master/locale/en-US/feeds.properties#L5 I'll land my patch whenever the tree re-opens...
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7d774ea78c6b
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7d774ea78c6b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•