Closed Bug 983453 Opened 10 years ago Closed 10 years ago

Re-enable whatsnew/firstrun page for Nightly builds

Categories

(Firefox :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 31
Tracking Status
firefox31 --- verified

People

(Reporter: jbertsch, Assigned: adw)

References

()

Details

(Whiteboard: p=1 s=it-31c-30a-29b.1 [qa!])

Attachments

(1 file, 1 obsolete file)

Please turn on firstrun for Nightly after https://bugzilla.mozilla.org/show_bug.cgi?id=964919 is resolved.

I'll add a more exact date in the next week or so.

Thanks.
Whiteboard: p=0
(In reply to Jennifer Bertsch [:jbertsch] from comment #0)
> Please turn on firstrun for Nightly after
> https://bugzilla.mozilla.org/show_bug.cgi?id=964919 is resolved.

Could we go ahead and get this turned back on in Nightlies before bug 964919 is fixed?  That is just about improving the page -- the page is currently live with information about QA contribution opportunities.
Status: NEW → ASSIGNED
Whiteboard: p=0 → p=1 s=it-31c-30a-29b.1
Assignee: nobody → adw
Attached patch patchSplinter Review
Is this all?  Reverting the Nightly part of bug 486660?
Attachment #8393184 - Flags: review?(gavin.sharp)
I thought that this bug was just about firstrun, not whatsnew but I could be wrong.
Flags: needinfo?(jbertsch)
Depends on: 964928
No longer depends on: 964919
Flags: needinfo?(jbertsch)
1.  Yes this bug is only for firstrun.

2.  Yes sorry - this bug doesn't depend on 964919 but on 964928, which I think we can resolve this week.
Comment on attachment 8393184 [details] [diff] [review]
patch

Matt's right - we want only the homepage_welcome_url pref ("firstrun", used on first start of a new profile) but not the homepage_override_url ("whatsnew", used on every version change).
Attachment #8393184 - Flags: review?(gavin.sharp) → review-
Just to confirm, a first run page would only be shown once to people the first time they install Nightly?

Ideally we would also be able to get contribution information in front of regular Nightly users -- in particular this would be useful if we commit to keeping that page up to date with timely information about where we need help.  For example, this is the thing we want you to test this week.

My memory of the experience with Nightlies before was that the page on www.mozilla.org was shown each time the Nightly got updated.  Can someone confirm how this had been configured in the past?
So to clarify, I'm suggesting turning this back on as both a first run and what's new page.
Paul, can you please take ownership of ensuring this gets signed off when fixed?
QA Contact: paul.silaghi
Whiteboard: p=1 s=it-31c-30a-29b.1 → p=1 s=it-31c-30a-29b.1 [qa+]
Attached patch patch v2 (obsolete) — Splinter Review
(In reply to David Boswell from comment #6)
> My memory of the experience with Nightlies before was that the page on
> www.mozilla.org was shown each time the Nightly got updated.  Can someone
> confirm how this had been configured in the past?

I remember that, too.  If that's the "what's new" page, then it was disabled by bug 486660 in May 2013 if I'm reading it right, "because the current pages are out of date and we don't currently have anything better to point them to."
Attachment #8393184 - Attachment is obsolete: true
Attachment #8393900 - Flags: review?(gavin.sharp)
(In reply to Drew Willcoxon :adw from comment #9)
> I remember that, too.  If that's the "what's new" page, then it was disabled
> by bug 486660 in May 2013 if I'm reading it right, "because the current
> pages are out of date and we don't currently have anything better to point
> them to."

Thanks for the context around why the first run and what's new pages were turned off for Nightlies in bug 486660.  I agree that at the time, those pages weren't well owned and they weren't up to date.

This has changed with the goal to grow community by 10x this year and things are well owned now -- as demonstrated by activity around updating the content and redesigning the Nightly page on www.mozilla.org.

Considering this, I'm updating the description of this bug to reflect that we want to re-enable what was disabled in bug 486660.
Summary: turn on firstrun for Nightly → Re-enable whatsnew/firstrun page for Nightly builds
Great!  I'm 100% ok with the new page coded in bug 964928 living at both the firstrun and whatsnew URLs for Nightly.

Thanks everyone.
Comment on attachment 8393900 [details] [diff] [review]
patch v2

I guess we're going back to the v.1 patch now that we know mozilla.org is ready for both
Attachment #8393900 - Flags: review?(gavin.sharp) → review-
Comment on attachment 8393184 [details] [diff] [review]
patch

I double-checked in the code that startup.homepage_override_url is only used for mstone changes (and not buildid changes which would mean daily).
Attachment #8393184 - Flags: review- → review+
Attachment #8393900 - Attachment is obsolete: true
Attachment #8393184 - Attachment is obsolete: false
(In reply to Jennifer Bertsch [:jbertsch] from comment #11)
> Great!  I'm 100% ok with the new page coded in bug 964928 living at both the
> firstrun and whatsnew URLs for Nightly.

The content on that page doesn't really look like it would be particularly relevant for Nightly users to see every 6 weeks. I think it does make sense for new Nightly users.

Why would we want this for whatsnew, if it's not actually answering the "what's new" question?
(In reply to :Gavin Sharp (email gavin@gavinsharp.com) from comment #14)
> The content on that page doesn't really look like it would be particularly
> relevant for Nightly users to see every 6 weeks. I think it does make sense
> for new Nightly users.
> 
> Why would we want this for whatsnew, if it's not actually answering the
> "what's new" question?

It does deal with that somewhat in a small way in that there is a link to the australis tour. My ideal version of the page would be updated regularly to call out new features to get testing on them. Embedding the @FirefoxNightly twitter account would probably be an easy way to help with that.
(In reply to Matthew N. [:MattN] from comment #15)
> It does deal with that somewhat in a small way in that there is a link to
> the australis tour. My ideal version of the page would be updated regularly
> to call out new features to get testing on them. Embedding the
> @FirefoxNightly twitter account would probably be an easy way to help with
> that.

This is great feedback -- and I completely agree about needing to provide timely and relevant information to Nightly users on this page.  That's the goal with the redesign effort in bug 964919.

I'll add the suggestion about embedding the @FirefoxNightly twitter account in the page to that bug.
https://hg.mozilla.org/mozilla-central/rev/84f4e3fd62b1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Hi Paul, could you let me know when verification for this item will be completed?  Our iteration ends on Monday, March 31st.
Flags: needinfo?(paul.silaghi)
Hi Jenn,
Nightly 2014-03-26 just got out, so probably tomorrow, EET.

Couple of observations:
1. (In reply to Jennifer Bertsch [:jbertsch] from comment #4)
> 2.  Yes sorry - this bug doesn't depend on 964919 but on 964928, which I
> think we can resolve this week.
Both bugs are not resolved yet.

2. The main video from http://www.mozilla.org/en-US/firefox/nightly/firstrun/ doesn't play -> "No video with supported format and MIME type found" error message is displayed

3. (In reply to David Boswell from comment #10)
> Considering this, I'm updating the description of this bug to reflect that
> we want to re-enable what was disabled in bug 486660.
> Summary: turn on firstrun for Nightly → Re-enable whatsnew/firstrun page for Nightly builds
What's the connection with the whatsnew page? I only see the firstrun page now
Flags: needinfo?(paul.silaghi)
Flags: needinfo?
(In reply to Paul Silaghi, QA [:pauly] from comment #20)
> What's the connection with the whatsnew page? I only see the firstrun page
> now

I'd like to use the same page on www.mozilla.org for both the firstrun and whatsnew page.  The idea is to keep that page up to date with relevant contribution opportunities so it could serve as useful content for both new and existing Nightly users.

Not sure if the URL for the page would need to change so that it could serve as both firstrun and whatsnew?
Flags: needinfo?
(In reply to Paul Silaghi, QA [:pauly] from comment #20)
> Hi Jenn,
> Nightly 2014-03-26 just got out, so probably tomorrow, EET.

To test the whatsnew case - before you apply the update from this build, modify the browser.startup.homepage_override.mstone pref in about:config. eg set it to '30.0a1'.
(In reply to Nick Thomas [:nthomas] from comment #22)
> To test the whatsnew case - before you apply the update from this build,
> modify the browser.startup.homepage_override.mstone pref in about:config. eg
> set it to '30.0a1'.
Ok, http://www.mozilla.org/en-US/firefox/nightly/firstrun/?oldversion=30.0a1 is displayed.
So basically firstrun page(http://www.mozilla.org/en-US/firefox/nightly/firstrun) and whatsnew page(http://www.mozilla.org/en-US/firefox/nightly/firstrun/?oldversion=30.0a1) are the same.
Is that correct?
Flags: needinfo?
(In reply to Paul Silaghi, QA [:pauly] from comment #23)
> (In reply to Nick Thomas [:nthomas] from comment #22)
> > To test the whatsnew case - before you apply the update from this build,
> > modify the browser.startup.homepage_override.mstone pref in about:config. eg
> > set it to '30.0a1'.
> Ok, http://www.mozilla.org/en-US/firefox/nightly/firstrun/?oldversion=30.0a1
> is displayed.
> So basically firstrun
> page(http://www.mozilla.org/en-US/firefox/nightly/firstrun) and whatsnew
> page(http://www.mozilla.org/en-US/firefox/nightly/firstrun/?oldversion=30.
> 0a1) are the same.
> Is that correct?

Yes - for now and the short term (next 3-6 months) they will show the same content.
Flags: needinfo?
Firstrun page is displayed when starting FF with a new profile, whatsnew page is displayed when upgrading from a lover version. Verified fixed FF 31.0a1 (2014-03-28), Win 7, Ubuntu 13.04, Mac OS X 10.8.5

Note:
1. The main video doesn't work
2. On Mac OS X, the upgrade is made progressively, so nightly 30.0a1 upgrades first to 31.0a1(2014-03-18) and only then to the latest nightly. So, the whatsnew page won't show up in this situation, I had to manually tweak the browser.startup.homepage_override.mstone pref to see it.
Status: RESOLVED → VERIFIED
Whiteboard: p=1 s=it-31c-30a-29b.1 [qa+] → p=1 s=it-31c-30a-29b.1 [qa!]
(In reply to Paul Silaghi, QA [:pauly] from comment #25)
> Firstrun page is displayed when starting FF with a new profile, whatsnew
> page is displayed when upgrading from a lover version. Verified fixed FF
> 31.0a1 (2014-03-28), Win 7, Ubuntu 13.04, Mac OS X 10.8.5

I checked Google Analytics for the page and am seeing an increase in traffic.

> Note:
> 1. The main video doesn't work

The video will be replaced soon with an update to the page.
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Depends on: 995867
You need to log in before you can comment on or make changes to this bug.