983500 - Australis: addons' toolbar button height is incorrect

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: smallbutton.xpi

OK, this is a weird one.

On Mac, our the buttons on our toolbar are sized too small vertically. The image is 12 pixels high instead of 16. This only affects are standalone buttons, not menu or menu-buttons.

The attached XPI shows the problem, but anything else I try to do to reduce the problem causes it not to happen.

This includes moving any content from the two overlays into one file, or removing any of the attributes that are left on the toolbar.

The testcase is fairly reduced, though.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Screenshot of problem.

Here's a comparison of Australis and non Australis

Comment 2

[Justin Dolske [:Dolske]]

Buttons from 2 addons I have, as well as other Firefox-supplied buttons, look fine on the bookmarks toolbar.

Comment 3

[Mike Kaply [:mkaply]]

(In reply to Justin Dolske [:Dolske] from comment #2)
> Buttons from 2 addons I have, as well as other Firefox-supplied buttons,
> look fine on the bookmarks toolbar.

So based on that you're not going investigate the bug at all? We have an add-on with millions of users that shows the problem, and it was working a few weeks ago.

Would finding the regression range help?

Comment 4

[Mike Kaply [:mkaply]]

The align="center" on the toolbar seemed to be the core source of the problem. I'm not sure why.

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to Mike Kaply (:mkaply) from comment #3)
> Would finding the regression range help?

Yes, that would be good to know.

Comment 6

[Logan Rosen [:Logan]]

I can't reproduce this with with the latest nightly build (2014-03-14) on OS X 10.9.2.

Comment 7

[Mike Kaply [:mkaply]]

(In reply to Logan Rosen [:Logan] from comment #6)
> I can't reproduce this with with the latest nightly build (2014-03-14) on OS
> X 10.9.2.

Nor can I. Any idea what fixed it?

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Closing as WFM.