983616 - [Search] Pass in region for faster marketplace searches

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect, P2)

Description

[Kevin Grandon :kgrandon]

Some notes from :mat in bug 978736: 

One thing you can do right now is specifying the region in the querystring, or "region=None" to disable region filtering completely. I'm on IRC if you want to discuss this because it's complex. Quick summary: Right now, without that parameter, we are going through geoip to try to find your region and filter accordingly.

If you want to pass the region, here is what we are doing on the Marketplace front-end: https://github.com/mozilla/fireplace/blob/master/hearth/media/js/mobilenetwork.js (at the moment you can ignore the carrier parameter - we don't currently filter with it)

If you want to disable it, passing region=None, be aware that the apps you'll get might not be available for the user (either because it requires payments - which can be impossible for their region - or simply because the developer has chosen to exclude the app from their region)

Comment 1

[Mathieu Pillard [:mat]]

This will no longer be necessary when bug 915701 is finished (the filtering on region will be gone entirely from the API).

Since Rocketbar currently leads you to the Marketplace, it's probably acceptable to have the autosuggest return apps that are potentially unavailable in your region - the Marketplace app will show the user that the app is not available.

Comment 2

[Kevin Grandon :kgrandon]

Since bug 915701 is now resolved, it seems that we may not need to solve this.

Comment 3

[Mathieu Pillard [:mat]]

Sorry, I just been doing some more tests, and found out that you actually need to pass the region for now.

The reason is, even though I removed region filtering for this API, if you don't pass a region when making an API call, we systematically call geoip even if it's not necessary.

TL;DR: pass region=restofworld in the query string, it will help performance.

Comment 4

[Kevin Grandon :kgrandon]

Mat - quick question. I'm looking at how to do this from the gaia side and not entirely sure.

Can we pass in a mcc value from the sim card? I'm not finding an easy-to-access "region name" in gaia like "en", "uk", and it loooks like this is what you're expecting? Thanks!

Comment 5

[Mathieu Pillard [:mat]]

We do mcc->region conversion on the client side, the API doesn't know about it. But it shouldn't matter, just use region=restofworld, the filtering is already off, it's just to avoid the geoip request (see comment 3)

Comment 6

[Kevin Grandon :kgrandon]

Guess we should start fixing some search bugs, taking :)

Comment 7

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8421254 [details] [review]
Github pull request

Hey Mat/Dale - have a sec to take a look at this? Thanks!

Comment 9

[Dale Harvey (:daleharvey)]

Comment on attachment 8421254 [details] [review]
Github pull request

r+ and merged as its a minor change

https://github.com/mozilla-b2g/gaia/commit/7a5ab0709189556f9b212126d41c052b26e98ae7

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8421254 [details] [review]
Github pull request

Thanks! Mat - if you have any follow-up comments/concerns please let me know.

Comment 11

[Kevin Grandon :kgrandon]

Oh oops - I saw that I still had a pull request open, but landed this anyway after it was landed. I don't think anything bad happens, but another commit may or may not be here: https://github.com/mozilla-b2g/gaia/commit/7a68501f3aeee0b7bbcfb2185a879bdadac26772