983626 - InvalidStateError constantly reported in logcat when putting device in sleep mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

With current gecko/gaia master running on Nexus S, I constantly get an InvalidStateError reported in logcat:
E/GeckoConsole(  703): [JavaScript Error: "InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable" {file: "app://system.gaiamobile.org/js/dialer_ringer.js" line: 153}]

STR:
 0. Run |adb logcat|
 1. Press power, unlock your device
 2. Press power to put it to sleep

Expected:
 No error in logcat

Actual:
 The reported error is being displayed each time.

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Comment 2

[Etienne Segonzac (:etienne)]

Alex can you confirm that this fixes this *and* bug 983624? (and dupe appropriately :))

Comment 3

[:gerard-majax]

(In reply to Etienne Segonzac (:etienne) from comment #2)
> Alex can you confirm that this fixes this *and* bug 983624? (and dupe
> appropriately :))

No, it fixes none.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8391168 [details] [review]
Gaia PR

Might be a different issue, clearing the review until then.

Comment 5

[:gerard-majax]

(In reply to Etienne Segonzac (:etienne) from comment #4)
> Comment on attachment 8391168 [details] [review]
> Gaia PR
> 
> Might be a different issue, clearing the review until then.

Only doing .pause(), not touching .currentTime fixes both.

Comment 6

[Etienne Segonzac (:etienne)]

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> (In reply to Etienne Segonzac (:etienne) from comment #4)
> > Comment on attachment 8391168 [details] [review]
> > Gaia PR
> > 
> > Might be a different issue, clearing the review until then.
> 
> Only doing .pause(), not touching .currentTime fixes both.

Well we need to reset the current time :)
But I'm sure Paul will have an idea :)

Comment 8

[Paul Adenot (:padenot)]

Clearing needinfo, I walked to Alexandre's desk to debug.

Comment 9

[:gerard-majax]

Just commented on github that after debugging with paul, the correct condition is:
> if (this._player.readyState > this._player.HAVE_NOTHING) {

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8391168 [details] [review]
Gaia PR

Updated the PR, can you confirm that this fixes the nexus S issue before I ask for review? Thanks.

Comment 11

[:gerard-majax]

Comment on attachment 8391168 [details] [review]
Gaia PR

Yes, with this change I'm not able to reproduce anymore the InvalidStateError and vibration correctly stops.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8391168 [details] [review]
Gaia PR

r+ with comment addressed.

Comment 13

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/3ad16c6017b78f6f7d0008f75ac16af011fcb14c

Comment 14

[:gerard-majax]

FYI I spotted this one a couple of times on my Inari that does not have this fix. This confirm there is nothing Nexus S specific there.