Open Bug 983654 Opened 11 years ago Updated 1 year ago

IonMonkey: Clean-up: Rename VMFunction::{Word,Double}By{Value,Ref} to match its original meaning.

Categories

(Core :: JavaScript Engine: JIT, enhancement, P5)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

People

(Reporter: nbp, Unassigned)

References

(Blocks 1 open bug)

Details

Originally, I made the VMFunction data type to represent that we are transferring data of different sizes and that they are transfered differently. I chose terrible names which have confused many person reading this code. Word -- sizeof(uintptr_t) Double -- 2 * sizeof(uintptr_t) ByValue -- Transfered by copy ByRef -- transfered by taking a reference to the location. These 2 where the only fields and this lead to complex bit arithmetics for unpacking as well as getting properties about each arguments. Now we have other kind of properties on the arguments, and it might be good to just split this one as well.
Severity: normal → S3
Blocks: sm-jits
Severity: S3 → N/A
Type: defect → enhancement
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.