983655 - Star icon is not aligned in the overflowed panel

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Alice0775 White]

Attachment: screenshot

Build Identifier:
https://hg.mozilla.org/mozilla-central/rev/f073b3d6db1f
Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140314030202

Str
1. Shrink browser window so that StarUI is in overflowed panel
2. Open overflowed panel

Actual Results:
Star Icon is slightly placed to the left in comparison with other icons

Comment 1

[Alice0775 White]

Regression window(gx)
Good:
http://hg.mozilla.org/integration/fx-team/rev/a7ec92db9f0b
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140122040406
Bad:
http://hg.mozilla.org/integration/fx-team/rev/767ee9d0f0c1
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140122043633
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a7ec92db9f0b&tochange=767ee9d0f0c1

Regressed by:
767ee9d0f0c1	Mike de Boer — [Australis] Bug 916953: introduce separator in overflow panel buttons and bookmark star button gets different label when inside overflow panel. r=Gijs

Comment 2

[Mike de Boer [:mikedeboer]]

Thanks Alice! That's a long time ago... I'll take it.

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: fix combined and menu-button buttons styling in the overflow panel

The change to the padding of the zoom-reset-button is a drive-by fix and can be moved to a separate bug.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8392259 [details] [diff] [review]
Patch v1: fix combined and menu-button buttons styling in the overflow panel

Review of attachment 8392259 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming you've tested on Windows and Linux, as both of my build envs on those are a little messed up right now.

Also, is it just me or is the zoom button padding change fixing bug 984568? Please mark as a dep and close appropriately. Thanks!

Comment 5

[Mike de Boer [:mikedeboer]]

Pushed without the changes for the zoom-reset label, because that needs more work.

https://hg.mozilla.org/integration/fx-team/rev/ce510a8c2af9

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ce510a8c2af9

Comment 7

[:Gijs (he/him)]

Comment on attachment 8392259 [details] [diff] [review]
Patch v1: fix combined and menu-button buttons styling in the overflow panel

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: bookmarks button looks odd when in the overflow panel
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, CSS-only change.
String or IDL/UUID changes made by this patch: none

Comment 8

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/a5052e8ce163
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/14833d153e6a

Comment 9

[Paul Silaghi, QA [:pauly]]

Reproduced in Nightly 2014-03-13.
Verified fixed 31.0a1 (2014-03-20), Ubuntu 13.04 x64.

Comment 11

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 29b2, 30.0a2 (2014-03-25) on Ubuntu 12.04 x86.