983657 - thumbstick navigation triggers unwarranted zooming

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tim Beltran]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.146 Safari/537.36

Steps to reproduce:

Using a joystick to browse usually works but it can get caught moving a direction or zooming because of dead-zones.


Actual results:

Continues to zoom or move in a direction after stick is released. Deadzone on joysticks should be increased if you're gonna use them for movement I'm assuming.


Expected results:

Move to a direction; or zoom to a size; and stop.

Comment 1

[Tim Beltran]

Ouya Console

Comment 2

[Aaron Train [:aaronmt]]

I've seen this once before a long time ago with an Xbox 360 controller

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Yeah this is a little tricky to calibrate across all devices. We use the hardware-provided dead zone threshold which doesn't always work right. There is a pref you can use to override it though. Go to about:config and set the ui.scrolling.gamepad_dead_zone pref to something bigger. The allowed range is from 0-1000, where 0 is no dead zone and 1000 is everything is a dead zone. It currently defaults to 10.

Comment 4

[Tim Beltran]

Pumped it up and up until I got NO bleed after controlling for a few minutes and the lowest number I got to work was 115. anything sub 100 still ran without inputs after some time.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Good to know, thanks. I'd like to get feedback from people with other controllers too before actually making the change in the code.

Comment 6

[Tim Beltran]

I have multiple usb controllers and another input with a joystick will get back to you later on how it goes.

Comment 7

[Tim Beltran]

Logitech f310 and dual action both work but if I push all the way the scroll jumps/stops; SGC2909/27 Phillips controller deadzone was spot on; IONTICS ID-M100 scroll works as well.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

(In reply to Tim Beltran from comment #7)
> Logitech f310 and dual action both work but if I push all the way the scroll
> jumps/stops

Not sure quite what you mean here. Do you mean the scroll becomes jumpy instead of smooth? For some controllers moving the joystick all the way to the end acts like a d-pad, so it might be that we're getting button events instead of an analog input event, and so scrolling by a fixed increment.

>SGC2909/27 Phillips controller deadzone was spot on; IONTICS
> ID-M100 scroll works as well.

Were these with the default pref value, or with the change you made (to 115)?

Comment 9

[Tim Beltran]

(In reply to (PTO|Mar15-Mar19) Kartikaya Gupta (email:[e-mail]) from comment #8)

> Not sure quite what you mean here. Do you mean the scroll becomes jumpy
> instead of smooth? For some controllers moving the joystick all the way to
> the end acts like a d-pad, so it might be that we're getting button events
> instead of an analog input event, and so scrolling by a fixed increment.

The logitech controllers what I mean is; if I press the joystick halfway it scrolls smoothly if I press the joystick all the way to the end of it's range it will stop moving.

> Were these with the default pref value, or with the change you made (to 115)?

Changed value.  Reverting to the other number causes zooming/panning after I let go of the buttons.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

(In reply to Tim Beltran from comment #9)
> The logitech controllers what I mean is; if I press the joystick halfway it
> scrolls smoothly if I press the joystick all the way to the end of it's
> range it will stop moving.

Hm. That sounds like a combination of what I said and the issue you described in https://bugzilla.mozilla.org/show_bug.cgi?id=831781#c28 where the d-pad isn't working at all. (i.e. the controllers are sending d-pad input at the end of the range, and we end up ignoring it).

> > Were these with the default pref value, or with the change you made (to 115)?
> 
> Changed value.  Reverting to the other number causes zooming/panning after I
> let go of the buttons.

Ok, I can update our default to use that then.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Increase deadzone size

Comment 12

[Chris Lord [:cwiiis]]

Comment on attachment 8391299 [details] [diff] [review]
Increase deadzone size

Review of attachment 8391299 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Maybe add a comment above with reference to this bug to explain the number chosen?

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Attachment: Increase deadzone size (v2)

Done; carrying r+

Comment 14

[Tim Beltran]

As far as I'm concerned issue has been resolved by increasing deadzone to 115 thank you guys.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/8fc8c9171c1f

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8fc8c9171c1f