Closed Bug 983657 Opened 6 years ago Closed 6 years ago

thumbstick navigation triggers unwarranted zooming

Categories

(Firefox for Android :: General, defect)

30 Branch
All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: timothybeltran515, Assigned: kats)

References

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.146 Safari/537.36

Steps to reproduce:

Using a joystick to browse usually works but it can get caught moving a direction or zooming because of dead-zones.


Actual results:

Continues to zoom or move in a direction after stick is released. Deadzone on joysticks should be increased if you're gonna use them for movement I'm assuming.


Expected results:

Move to a direction; or zoom to a size; and stop.
OS: Windows 7 → Android
Hardware: x86_64 → All
Ouya Console
I've seen this once before a long time ago with an Xbox 360 controller
Blocks: ouya
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: joystick browsing → thumbstick navigation triggers unwarranted zooming
Yeah this is a little tricky to calibrate across all devices. We use the hardware-provided dead zone threshold which doesn't always work right. There is a pref you can use to override it though. Go to about:config and set the ui.scrolling.gamepad_dead_zone pref to something bigger. The allowed range is from 0-1000, where 0 is no dead zone and 1000 is everything is a dead zone. It currently defaults to 10.
Pumped it up and up until I got NO bleed after controlling for a few minutes and the lowest number I got to work was 115. anything sub 100 still ran without inputs after some time.
Good to know, thanks. I'd like to get feedback from people with other controllers too before actually making the change in the code.
I have multiple usb controllers and another input with a joystick will get back to you later on how it goes.
Logitech f310 and dual action both work but if I push all the way the scroll jumps/stops; SGC2909/27 Phillips controller deadzone was spot on; IONTICS ID-M100 scroll works as well.
(In reply to Tim Beltran from comment #7)
> Logitech f310 and dual action both work but if I push all the way the scroll
> jumps/stops

Not sure quite what you mean here. Do you mean the scroll becomes jumpy instead of smooth? For some controllers moving the joystick all the way to the end acts like a d-pad, so it might be that we're getting button events instead of an analog input event, and so scrolling by a fixed increment.

>SGC2909/27 Phillips controller deadzone was spot on; IONTICS
> ID-M100 scroll works as well.

Were these with the default pref value, or with the change you made (to 115)?
(In reply to (PTO|Mar15-Mar19) Kartikaya Gupta (email:kats@mozilla.com) from comment #8)

> Not sure quite what you mean here. Do you mean the scroll becomes jumpy
> instead of smooth? For some controllers moving the joystick all the way to
> the end acts like a d-pad, so it might be that we're getting button events
> instead of an analog input event, and so scrolling by a fixed increment.

The logitech controllers what I mean is; if I press the joystick halfway it scrolls smoothly if I press the joystick all the way to the end of it's range it will stop moving.

> Were these with the default pref value, or with the change you made (to 115)?

Changed value.  Reverting to the other number causes zooming/panning after I let go of the buttons.
(In reply to Tim Beltran from comment #9)
> The logitech controllers what I mean is; if I press the joystick halfway it
> scrolls smoothly if I press the joystick all the way to the end of it's
> range it will stop moving.

Hm. That sounds like a combination of what I said and the issue you described in https://bugzilla.mozilla.org/show_bug.cgi?id=831781#c28 where the d-pad isn't working at all. (i.e. the controllers are sending d-pad input at the end of the range, and we end up ignoring it).

> > Were these with the default pref value, or with the change you made (to 115)?
> 
> Changed value.  Reverting to the other number causes zooming/panning after I
> let go of the buttons.

Ok, I can update our default to use that then.
Attached patch Increase deadzone size (obsolete) — Splinter Review
Assignee: nobody → bugmail.mozilla
Attachment #8391299 - Flags: review?(chrislord.net)
Comment on attachment 8391299 [details] [diff] [review]
Increase deadzone size

Review of attachment 8391299 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Maybe add a comment above with reference to this bug to explain the number chosen?
Attachment #8391299 - Flags: review?(chrislord.net) → review+
Done; carrying r+
Attachment #8391299 - Attachment is obsolete: true
Attachment #8391373 - Flags: review+
As far as I'm concerned issue has been resolved by increasing deadzone to 115 thank you guys.
https://hg.mozilla.org/mozilla-central/rev/8fc8c9171c1f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
You need to log in before you can comment on or make changes to this bug.