983721 - "Unsorted Bookmarks" icon should be blue for consistency

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[alex_mayorga]

"Unsorted Bookmarks" icon shall be blue for consistency.

Comment 1

[alex_mayorga]

Attachment: Bug-983721.png

Comment 2

[Justin Dolske [:Dolske]]

Steven: need an updated icon for this

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Stephen, is this something we still want to do? Maybe could be mentored to some new ux contributor?

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: places-icons-windows.zip

(In reply to Marco Bonardo [::mak] from comment #3)
> Stephen, is this something we still want to do? Maybe could be mentored to
> some new ux contributor?

Yes! We had all of the Windows places icons updated a few months ago for HiDPI and as part of the Windows 10 work. I would like to update them all at once and remove all of the various platform variations. We could change this bug into that or file a new one?

Attaching the assets. This is what they look like: http://people.mozilla.org/~shorlander/bugs/bug-983721-places-icons.png

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I don't have preferences re: this bug VS a new bug.
who is responsible for this work? The UI quality team? Dolske can you evaluate this?

Comment 6

[Justin Dolske [:Dolske]]

This might be a good bug for Katie?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, this will be good. I've put it in our backlog.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Glenn, would you like to work on this bug?

Comment 9

[Glenn Fernandes [:torroid]]

Yes. I'll give it a try.

Comment 10

[Glenn Fernandes [:torroid]]

Attachment: Changed the files

I don't know if what I have done is right or not.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8786398 [details] [diff] [review]
Changed the files

Something isn't right with the attached patch. It says that each one of these binary files has changed but the patch should include the actual binary changes.

How did you create this patch?

Comment 12

[Glenn Fernandes [:torroid]]

Attachment: Replaced unsortedBookmarks.png with the new file containing blue color.

I think this one is okay.
While creating the previous patch there was a small issue.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8786458 [details] [diff] [review]
Replaced unsortedBookmarks.png with the new file containing blue color.

Review of attachment 8786458 [details] [diff] [review]:
-----------------------------------------------------------------

Okay this patch was created correctly. Can you please update all of the other images that were in the ZIP file?

Comment 14

[Glenn Fernandes [:torroid]]

Attachment: Added files in windows/places/

I've added the other files too.

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8787334 [details] [diff] [review]
Added files in windows/places/

Review of attachment 8787334 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the updated patch. Still some files are missing and some CSS changes will need to be made.

The @2x versions will need to be defined in a "@media (min-resolution: 1.1dppx)" media query following their @1x (default) styling. When you add the files, they will also need to be added to their corresponding jar.mn file.

Need to be added along with CSS changes to use the @2x version:
browser/themes/windows/places/[e-mail]
browser/themes/windows/places/[e-mail]
browser/themes/windows/places/[e-mail]
toolkit/themes/windows/global/dirListing/[e-mail]
toolkit/themes/windows/global/icons/[e-mail]
browser/themes/windows/places/[e-mail]
browser/themes/windows/[e-mail]
browser/themes/windows/places/[e-mail]
browser/themes/windows/places/[e-mail]

Files still needing to be replaced:
browser/themes/windows/places/bookmarksToolbar-menuPanel.png
toolkit/themes/windows/global/dirListing/folder.png
toolkit/themes/windows/global/icons/folder-item.png
browser/themes/windows/livemark-folder.png

You can test out the @2x versions by going to about:config and changing layout.css.devPixelsPerPx to 1.25.

Comment 16

[Glenn Fernandes [:torroid]]

Hey I have a small doubt. What is "%override chrome:// ....." in the jar.mn file?

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

Here's a link to documentation about override, https://developer.mozilla.org/en-US/docs/Chrome_Registration#override

In short, when you see a line like:
> % override chrome://browser/skin/Info.png chrome://browser/skin/Info-XP.png os=WINNT osversion<6

What this is saying is that if the operating system is Windows and it is less than version 6, which would equal Windows XP and anything earlier, then use the Info-XP.png graphic instead of the Info.png graphic.

When "chrome://browser/skin/Info.png" is requested, because of the override "chrome://browser/skin/Info-XP.png" will actually be loaded.

Comment 18

[Jared Wein [:jaws] (please needinfo? me)]

Glenn, can I help you here?

Comment 19

[Glenn Fernandes [:torroid]]

Hi!
I have added the files in their respective folders and also made the changes in respective jar.mn files.
Im trying to figure out how to add the media@2x code to css.

Comment 20

[Jared Wein [:jaws] (please needinfo? me)]

Great! Let me know if I should help you with adding the media@2x code to the CSS.

Comment 21

[Glenn Fernandes [:torroid]]

Would this code be correct for media@2x? :

media(min-resolution: 1.1dppx){
    #(respective id){
      list-style-image: url of 2x image;
    }
}

Comment 22

[Jared Wein [:jaws] (please needinfo? me)]

Yes, that's right :)

Comment 23

[Jared Wein [:jaws] (please needinfo? me)]

After you add that CSS, you can test out the @2x versions by going to about:config and changing layout.css.devPixelsPerPx to 1.25.

Comment 24

[Glenn Fernandes [:torroid]]

I'm able to change the css code on the browser as well as change the config while testing, but I don't know where to add the respective image files.

Comment 25

[Jared Wein [:jaws] (please needinfo? me)]

You should add the @2x images in the same directory that the regular images are in. The jar.mn file should say where they're located.

Comment 26

[Jared Wein [:jaws] (please needinfo? me)]

Hi Glenn, are you still working on this?

Comment 27

[Glenn Fernandes [:torroid]]

Hi, working on it.

Comment 28

[Jared Wein [:jaws] (please needinfo? me)]

Hi Glenn, were you able to make any progress on this?

Comment 29

[Jared Wein [:jaws] (please needinfo? me)]

Glenn messaged me through IRC and said that he wouldn't be able to work on this right now.

Comment 30

[Tim Nguyen :ntim]

I believe we removed unsorted bookmarks, and most icons have been converted to monochrome SVGs.

Feel free to reopen if this is still valid.