983770 - Australis: Unexpected scroll bar appears when zoom widget is in overflowed panel

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Alice0775 White]

Attachment: screenshot

See Screenshot

Comment 1

[Alice0775 White]

reproduced on Ubuntu12.04

Comment 2

[Justin Dolske [:Dolske]]

(See also bug 983768 for the percentage being uncentered)

Comment 3

[:Gijs (he/him)]

I'm 90% sure this is a regression... :-(

Comment 4

[Alice0775 White]

Regression pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=45dda1081309&tochange=01e7d117df29

Comment 5

[:Gijs (he/him)]

Attachment: fix scrollbars in overflow panel when zoom or edit controls overflow,

I also noticed that the icons were 15x16 on my Windows machine when in customize mode, so I fixed that, too. The palette styling could be improved further, but that seems to not be entirely trivial (my immediate margin-bottom attempts didn't work) and outside of the scope of this bug, so...

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8394108 [details] [diff] [review]
fix scrollbars in overflow panel when zoom or edit controls overflow,

Review of attachment 8394108 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +861,5 @@
>  
> +/* Make direct siblings overlap borders: */
> +.toolbaritem-combined-buttons + .toolbaritem-combined-buttons@inAnyPanel@ {
> +  margin-top: -1px;
> +  border-top-color: transparent !important;

Why did you need to add !important here?

Comment 7

[:Gijs (he/him)]

(In reply to Mike de Boer [:mikedeboer] from comment #6)
> Comment on attachment 8394108 [details] [diff] [review]
> fix scrollbars in overflow panel when zoom or edit controls overflow,
> 
> Review of attachment 8394108 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
> @@ +861,5 @@
> >  
> > +/* Make direct siblings overlap borders: */
> > +.toolbaritem-combined-buttons + .toolbaritem-combined-buttons@inAnyPanel@ {
> > +  margin-top: -1px;
> > +  border-top-color: transparent !important;
> 
> Why did you need to add !important here?

Because I don't want to manually try to come up with selectors which override all the possible hover and active styles for the border, and have it break again at some point when the selectors for the hover/active cases change.

Comment 8

[Mike de Boer [:mikedeboer]]

Comment on attachment 8394108 [details] [diff] [review]
fix scrollbars in overflow panel when zoom or edit controls overflow,

Review of attachment 8394108 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 9

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/43b83424c05a

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/43b83424c05a

Comment 11

[:Gijs (he/him)]

Comment on attachment 8394108 [details] [diff] [review]
fix scrollbars in overflow panel when zoom or edit controls overflow,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: combined toolbar buttons cause scrollbar in the overflow menu
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, CSS-only change
String or IDL/UUID changes made by this patch: none

Comment 12

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/644d7391830e
https://hg.mozilla.org/releases/mozilla-beta/rev/b6cec4e79dfc

Comment 13

[Cornel Ionce [:noni] [Hubs QA]]

Verified this as fixed on Windows 7 64bit, Ubuntu 12.04 and Mac OS X 10.9 using:
- latest Aurora (build ID: 20140324150430)
- latest Nightly (build ID: 20140324030203)
- Firefox 29 beta 2 (build ID: 20140324101726).

The issue from the screenshot is no longer reproducing. Closing issue.