983807 - test_reprocessingjobs stops working after having run once

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Peter Bengtsson [:peterbe]]

So I run `setupdb_app.py --dropdb` and then run the crontabber/jobs/tests_* tests and it stops working after the first run.

Hopefully it's clear from:
https://gist.github.com/peterbe/9555817

So I could see how this sneaks past jenkins because there we never run the tests without first having run setupdb_app.py

Comment 1

[Robert Helmer [:rhelmer]]

This unit test appears to be dropping the table in question:

https://github.com/mozilla/socorro/blob/master/socorro/unittest/cron/jobs/test_reprocessingjobs.py#L88

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> This unit test appears to be dropping the table in question:
> 
> https://github.com/mozilla/socorro/blob/master/socorro/unittest/cron/jobs/
> test_reprocessingjobs.py#L88

Looks like it was introduced in https://github.com/mozilla/socorro/commit/3a46b97441777f97a86fbf1350cf1ccd81e03417

Comment 3

[Peter Bengtsson [:peterbe]]

Selena, 
I assigned it to you but I'm more than happy to work with you on it. 
It's probably not a good idea to do a table removal since we'd need to recreate it leaving the test. But perhaps you know something I don't :)

Comment 4

[Selena Deckelmann :selenamarie :selena]

Attachment: https://github.com/mozilla/socorro/pull/2012

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/60405b9a4dad61d392ef8f6625502b16fe3d36c0
Fixes bug 983807 change reprocessing exception test to only rename table, not remove

https://github.com/mozilla/socorro/commit/d022828c93ede0ed29133ebe221278413ac92174
Fixes bug 983807 use a try/finally r=peterbe

https://github.com/mozilla/socorro/commit/276964e9a90eb8a7929904d5fb5cf71bd825a798
Merge pull request #2012 from selenamarie/bug983807-reprocessingjobs-test-fix

Fixes bug 983807 change reprocessing exception test to rename not remove table