Closed Bug 983846 Opened 7 years ago Closed 7 years ago

Gaia calendar marionette tests are fugly like what

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S4 (28mar)

People

(Reporter: gaye, Assigned: gaye)

Details

(Whiteboard: [p=8])

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → gaye
Bikeshed!
Attachment #8392657 - Flags: feedback?(mmedeiros)
Attachment #8392657 - Flags: feedback?(jlal)
Attachment #8392657 - Flags: feedback?(evanxd)
Attachment #8392657 - Attachment is obsolete: true
Attachment #8392657 - Flags: feedback?(mmedeiros)
Attachment #8392657 - Flags: feedback?(jlal)
Attachment #8392657 - Flags: feedback?(evanxd)
Attachment #8393113 - Flags: review?(mmedeiros)
Comment on attachment 8393113 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17267

"That's one small step for a man, one giant leap for mankind".

really improves the readability and will make it easier to maintain integration tests going forward.

we just need to make sure we create a new bug to keep track of tests that still needs to be converted into the new structure (since this patch is WIP).

good thing to merge this as is is that we can start coding the new tests following this structure, will avoid redundant work. will also allow us to split the work between multiple devs.
Attachment #8393113 - Flags: review?(mmedeiros) → review+
Whiteboard: [p=8]
Target Milestone: --- → 1.4 S4 (28mar)
Landed on master https://github.com/mozilla-b2g/gaia/commit/4709cf2bece32684e7b4d918bae582e81af81011
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.