983860 - AndroidFxAccount.enableSyncing() log message says "Disabling"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

Copy-paste error, but this is a good first bug.  The string should say "Enabling":

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/authenticator/AndroidFxAccount.java#330

Comment 1

[ashwinswaroop93]

Can I take up this bug? I've cloned the repository and found where the bug exists.

Comment 2

[ashwinswaroop93]

Attachment: Patch file

Please review the patch and let me know if I need to make any changes.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8395419 [details] [diff] [review]
Patch file

Review of attachment 8395419 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks for the patch!

We'll take care of upstreaming this to the android-sync repo: https://github.com/mozilla-services/android-sync

Comment 4

[Nick Alexander :nalexander [he/him]]

> Please review the patch and let me know if I need to make any changes.

I see rnewman picked up the review, but thanks for contributing!  Is this your first contribution to Mozilla?  (I see New to Bugzilla by your name, which usually means yes.)  If so, thanks for joining us!

I've made sure Margaret, who tracks new contributors to Fennec, knows about this ticket.  I'd love to see you keep working with us to make Fennec great, and I recently saw Bug 949902, which could use somebody to take a look and improve it.  Interested?

Comment 5

[Nick Alexander :nalexander [he/him]]

margaret: I think this might be a first contribution, and would like to make sure Ashwin Swaroop gets mentioned in the Wednesday mobile meeting.

Comment 6

[:Margaret Leibovic]

(In reply to Nick Alexander :nalexander from comment #5)
> margaret: I think this might be a first contribution, and would like to make
> sure Ashwin Swaroop gets mentioned in the Wednesday mobile meeting.

Thanks for letting me know! I don't follow Android Sync bugs, so I would have missed this.

And thank you Ashwin for your contribution!

Comment 7

[Nick Alexander :nalexander [he/him]]

Sorry this took so long to land, ashwin:

https://github.com/mozilla-services/android-sync/commit/72308f33cff03d4e45ffaf4cbe532bcdca7cb550
https://hg.mozilla.org/integration/fx-team/rev/929355392ac9

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/929355392ac9