Closed Bug 983860 Opened 6 years ago Closed 6 years ago

AndroidFxAccount.enableSyncing() log message says "Disabling"

Categories

(Firefox for Android :: Android Sync, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: nalexander, Assigned: ashwinswaroop93)

Details

(Whiteboard: [mentor=nalexander][lang=java][good first bug][needs upstreaming])

Attachments

(1 file)

Copy-paste error, but this is a good first bug.  The string should say "Enabling":

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/authenticator/AndroidFxAccount.java#330
Whiteboard: [mentor=nalexander][lang=java][good first bug]
Can I take up this bug? I've cloned the repository and found where the bug exists.
Assignee: nobody → ashwinswaroop93
Status: NEW → ASSIGNED
Attached patch Patch fileSplinter Review
Please review the patch and let me know if I need to make any changes.
Attachment #8395419 - Flags: review?(nalexander)
Comment on attachment 8395419 [details] [diff] [review]
Patch file

Review of attachment 8395419 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks for the patch!

We'll take care of upstreaming this to the android-sync repo: https://github.com/mozilla-services/android-sync
Attachment #8395419 - Flags: review?(nalexander) → review+
Whiteboard: [mentor=nalexander][lang=java][good first bug] → [mentor=nalexander][lang=java][good first bug][needs upstreaming]
> Please review the patch and let me know if I need to make any changes.

I see rnewman picked up the review, but thanks for contributing!  Is this your first contribution to Mozilla?  (I see New to Bugzilla by your name, which usually means yes.)  If so, thanks for joining us!

I've made sure Margaret, who tracks new contributors to Fennec, knows about this ticket.  I'd love to see you keep working with us to make Fennec great, and I recently saw Bug 949902, which could use somebody to take a look and improve it.  Interested?
margaret: I think this might be a first contribution, and would like to make sure Ashwin Swaroop gets mentioned in the Wednesday mobile meeting.
Flags: needinfo?(margaret.leibovic)
(In reply to Nick Alexander :nalexander from comment #5)
> margaret: I think this might be a first contribution, and would like to make
> sure Ashwin Swaroop gets mentioned in the Wednesday mobile meeting.

Thanks for letting me know! I don't follow Android Sync bugs, so I would have missed this.

And thank you Ashwin for your contribution!
Flags: needinfo?(margaret.leibovic)
https://hg.mozilla.org/mozilla-central/rev/929355392ac9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.