Closed Bug 983951 Opened 12 years ago Closed 12 years ago

Intermittent test_preference.html | valid preference value (app.update.lastUpdateTime.addon-background-update-timer) - got 0, expected 1394837203

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Version:
28 Branch
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox29 unaffected, firefox30 fixed, firefox31 fixed, firefox-esr24 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox29 --- unaffected
firefox30 --- fixed
firefox31 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: schien)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

check-selective-set.patch
2.46 KB, patch
schien
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=36167028&tree=Mozilla-Central slave: t-w864-ix-104 15:46:43 INFO - 5128 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (browser.tabs.drawInTitlebar) 15:46:43 INFO - 5129 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (browser.tabs.drawInTitlebar) 15:46:43 INFO - 5130 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (plugin.scan.WindowsMediaPlayer) 15:46:43 INFO - 5131 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (plugin.scan.WindowsMediaPlayer) 15:46:43 INFO - 5132 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (mousewheel.transaction.ignoremovedelay) 15:46:43 INFO - 5133 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (mousewheel.transaction.ignoremovedelay) 15:46:43 INFO - 5134 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (plugin.default.state) 15:46:43 INFO - 5135 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (plugin.default.state) 15:46:43 INFO - 5136 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (full-screen-api.allow-trusted-requests-only) 15:46:43 INFO - 5137 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (full-screen-api.allow-trusted-requests-only) 15:46:43 INFO - 5138 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (browser.urlbar.trimURLs) 15:46:43 INFO - 5139 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (browser.urlbar.trimURLs) 15:46:43 INFO - 5140 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (font.name.cursive.x-ethi) 15:46:43 INFO - 5141 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (font.name.cursive.x-ethi) 15:46:43 INFO - 5142 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (privacy.donottrackheader.value) 15:46:43 INFO - 5143 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (privacy.donottrackheader.value) 15:46:43 INFO - 5144 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (devtools.webconsole.filter.secerror) 15:46:43 INFO - 5145 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (devtools.webconsole.filter.secerror) 15:46:43 INFO - 5146 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (font.size.inflation.minTwips) 15:46:43 INFO - 5147 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (font.size.inflation.minTwips) 15:46:43 INFO - 5148 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (network.IDN.whitelist.is) 15:46:43 INFO - 5149 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid hasUserValue (network.IDN.whitelist.is) 15:46:43 INFO - 5150 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | valid preference value (app.update.lastUpdateTime.addon-background-update-timer) - got 0, expected 1394837203 15:46:43 INFO - 5151 INFO TEST-INFO | MEMORY STAT vsize after test: 896856064 15:46:43 INFO - 5152 INFO TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 1893662720 15:46:43 INFO - 5153 INFO TEST-INFO | MEMORY STAT residentFast after test: 296280064 15:46:43 INFO - 5154 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 101624902 15:46:43 INFO - 5155 INFO TEST-END | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_preference.html | finished in 1060ms 15:46:43 INFO - 5156 INFO TEST-START | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_styles-applied.html 15:46:43 INFO - 5157 INFO TEST-INFO | MEMORY STAT vsize after test: 897511424 15:46:43 INFO - 5158 INFO TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 1893662720 15:46:43 INFO - 5159 INFO TEST-INFO | MEMORY STAT residentFast after test: 298659840 15:46:43 INFO - 5160 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 104919956
Blocks: 943251
Flags: needinfo?(schien)
Okey, iterating over all preferences maybe too extreme for test_preference.html. I'm going to pick some stable preference values for the verdict in test_preference.html.
Attached patch check-selective-set.patch (obsolete) — — Splinter Review
check a selective set of prefs instead of all prefs. let's see how it works on tpbl: https://tbpl.mozilla.org/?tree=Try&rev=aa7dd3ab6783
Assignee: nobody → schien
Attachment #8396952 - Flags: review?(jryans)
Flags: needinfo?(schien)
Comment on attachment 8396952 [details] [diff] [review] check-selective-set.patch Review of attachment 8396952 [details] [diff] [review]: ----------------------------------------------------------------- Seems fine overall, but check the one line I commented below. Also, you may get a conflict if my patch in bug 985652 lands first. ::: toolkit/devtools/server/tests/mochitest/test_preference.html @@ +74,3 @@ > > ["test.bool", "test.int", "test.string"].forEach(function(key) { > + ok(!prefs.hasOwnProperty(key), "expect no pref (" + key + ")"); Hmm, how would these keys ever end up on |prefs|? It seems impossible...
Attachment #8396952 - Flags: review?(jryans) → review+
(In reply to J. Ryan Stinnett [:jryans] from comment #23) > Comment on attachment 8396952 [details] [diff] [review] > check-selective-set.patch > > Review of attachment 8396952 [details] [diff] [review]: > ----------------------------------------------------------------- > > Seems fine overall, but check the one line I commented below. > > Also, you may get a conflict if my patch in bug 985652 lands first. > > ::: toolkit/devtools/server/tests/mochitest/test_preference.html > @@ +74,3 @@ > > > > ["test.bool", "test.int", "test.string"].forEach(function(key) { > > + ok(!prefs.hasOwnProperty(key), "expect no pref (" + key + ")"); > > Hmm, how would these keys ever end up on |prefs|? It seems impossible... My verdict for getAllPrefs() has two parts. This line is to make sure non-existed prefs never show up in the result of getAllPrefs() and line #54~#73 is for checking existed prefs appear in the result. @jryans, do you think that make sense to you?
Flags: needinfo?(jryans)
(In reply to Shih-Chiang Chien [:schien] (UTC+8) from comment #27) > (In reply to J. Ryan Stinnett [:jryans] from comment #23) > > Comment on attachment 8396952 [details] [diff] [review] > > check-selective-set.patch > > > > Review of attachment 8396952 [details] [diff] [review]: > > ----------------------------------------------------------------- > > > > Seems fine overall, but check the one line I commented below. > > > > Also, you may get a conflict if my patch in bug 985652 lands first. > > > > ::: toolkit/devtools/server/tests/mochitest/test_preference.html > > @@ +74,3 @@ > > > > > > ["test.bool", "test.int", "test.string"].forEach(function(key) { > > > + ok(!prefs.hasOwnProperty(key), "expect no pref (" + key + ")"); > > > > Hmm, how would these keys ever end up on |prefs|? It seems impossible... > > My verdict for getAllPrefs() has two parts. This line is to make sure > non-existed prefs never show up in the result of getAllPrefs() and line > #54~#73 is for checking existed prefs appear in the result. > > @jryans, do you think that make sense to you? Hmm, well no, not really. :) Here you are testing the object |prefs|, but that starts out as an empty object you create on line 38. You only ever assign the following keys to it: accessible, allPrefs, boolPref, intPref, and charPref on lines 86 - 93. Maybe you meant to check |prefs.allPrefs.hasOwnProperty| here? That would make more sense I think. If I still don't get it, come bug me on IRC. :)
Flags: needinfo?(jryans)
(In reply to J. Ryan Stinnett [:jryans] from comment #31) > > Maybe you meant to check |prefs.allPrefs.hasOwnProperty| here? That would > make more sense I think. If I still don't get it, come bug me on IRC. :) Yeah, you are right and I should check |pref.allPrefs.hasOwnProperty|. I was totally blind on this spot while I was writing the patch. Thanks for pointing this out!
https://hg.mozilla.org/integration/fx-team/rev/2c633dd0c85b
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2c633dd0c85b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: