984032 - (Synth APK) - APK Factory should return cached APK when network or origin manifest host is down

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Austin King [:ozten]]

+++ This bug was initially created as a clone of Bug #964845 +++

In doing some manual testing, I found that the Twitter apk file might not be returned, if Twitter starts rate-limiting us again.

Steps to Reproduce

1) Setup an open web app manifest that is easy to tweak
2) curl -v -k "${ENDPOINT}/application.apk?manifestUrl=${MANI}" -o ${APP}.apk

Note: Successful .apk generation

3) Stop server hosting your manifest

4) curl -v -k "${ENDPOINT}/application.apk?manifestUrl=${MANI}" -o ${APP}.apk

also

curl -v -H "Content-Type: application/json" -X POST -d '{ "installed":{"http://deltron3032.testmanifest.com/manifest.webapp":1394909578}}' https://localhost:8080/app_updates

Actual:

APK Factory doesn't return an APK
APK Factory says the APK is out of date

Expected:
APK from the cache is returned.
If update timestamp matches DB, then the outdated list is empty.

Comment 1

[Austin King [:ozten]]

After retrieving metadata form the DB, we check for the current value of the manifest.
If this fails, we ignore and log a warning.

https://github.com/mozilla/apk-factory-service/pull/60