Closed
Bug 984064
Opened 10 years ago
Closed 10 years ago
GStreamerAllocator.cpp:63:102: error: 'struct already_AddRefed<mozilla::layers::Image>' has no member named 'get' (--enable-gstreamer=1.0)
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(1 file)
|
1.13 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
content/media/gstreamer/GStreamerAllocator.cpp:63:102: error:
no member named 'get' in 'already_AddRefed<mozilla::layers::Image>'
...container->CreateImage(ImageFormat::PLANAR_YCBCR).get());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.
gmake[1]: *** [GStreamerAllocator.o] Error 1
Summary: GStreamerAllocator.cpp:63:102: error: 'struct already_AddRefed<mozilla::layers::Image>' has no member named 'get' → GStreamerAllocator.cpp:63:102: error: 'struct already_AddRefed<mozilla::layers::Image>' has no member named 'get' (--enable-gstreamer=1.0)
We renamed that to take(). Happy to rubberstamp whatever you need here to get it working.
The file doesn't use dont_AddRef so I guess s/get/take/ is fine.
Attachment #8391806 -
Flags: review?(khuey)
Comment on attachment 8391806 [details] [diff] [review] fix Review of attachment 8391806 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8391806 -
Flags: review?(khuey) → review+
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5870a4beef4d
Assignee: nobody → jbeich
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5870a4beef4d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•