Closed
Bug 984076
Opened 11 years ago
Closed 11 years ago
Suppress clang and gcc warnings in third-party code: sqlite3
Categories
(Core Graveyard :: SQL, defect, P4)
Core Graveyard
SQL
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
732 bytes,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
db/sqlite3/src/sqlite3.c:87119:5 [-Wtype-limits] comparison is always true due to limited range of data type
db/sqlite3/src/sqlite3.c:117982:28 [-Wsign-compare] comparison between signed and unsigned integer expressions
Attachment #8391823 -
Flags: review?(mak77)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8391823 [details] [diff] [review]
suppress-sqlite-warnings.patch
Review of attachment 8391823 [details] [diff] [review]:
-----------------------------------------------------------------
ideally we should report them upstream, but I think in the past we really didn't have a good history of reporting warnings, nor even the resources to do that. And I think these exist from quite some time.
Please remember to fix the check-in comment.
Attachment #8391823 -
Flags: review?(mak77) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•