Closed
Bug 984079
Opened 11 years ago
Closed 11 years ago
Suppress clang and gcc warnings in third-party code: protobuf
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
801 bytes,
patch
|
mmc
:
review+
|
Details | Diff | Splinter Review |
toolkit/components/protobuf/google/protobuf/io/coded_stream.cc:260:36 [-Wsign-compare] comparison between signed and unsigned integer expressions
toolkit/components/protobuf/google/protobuf/io/coded_stream.cc:277:36 [-Wsign-compare] comparison between signed and unsigned integer expressions
toolkit/components/protobuf/google/protobuf/io/coded_stream.cc:597:47 [-Wsign-compare] comparison between signed and unsigned integer expressions
toolkit/components/protobuf/google/protobuf/io/coded_stream.cc:612:47 [-Wsign-compare] comparison between signed and unsigned integer expressions
toolkit/components/protobuf/google/protobuf/io/zero_copy_stream_impl_lite.cc:159:36 [-Wsign-compare] comparison between signed and unsigned integer expressions
toolkit/components/protobuf/google/protobuf/stubs/common.cc:355:58 [-Wsign-compare] comparison between signed and unsigned integer expressions
Attachment #8391829 -
Flags: review?(mmc)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8391829 [details] [diff] [review]
suppress-protobuf-warnings.patch
Review of attachment 8391829 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, cpeterson!
Attachment #8391829 -
Flags: review?(mmc) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•