984081 - Suppress clang and gcc warnings in third-party code: harfbuzz

Status: RESOLVED WORKSFORME

(Core :: Graphics: Text, defect, P4)

Description

[Chris Peterson [:cpeterson]]

Attachment: suppress-harfbuzz-warnings.patch

gfx/harfbuzz/src/hb-common.cc:238:6 [-Wunused-function] unused function 'free_langs'

Comment 1

[Jonathan Kew [:jfkthame]]

Might be better to propose a patch upstream, rather than just suppressing the warning here. The free_langs() function could be wrapped in #ifdef HAVE_ATEXIT, just like the only callsite.

Comment 2

[Behdad Esfahbod]

Fixed upstream by merging Jonathan's pullrequest already.

Comment 3

[John Daggett (:jtd)]

Comment on attachment 8391831 [details] [diff] [review]
suppress-harfbuzz-warnings.patch

I agree with Jonathan, I think it would be better to have something upstream. Clearing the review for now.

Comment 4

[Chris Peterson [:cpeterson]]

I will try to submit an upstream patch. Two additional clang warnings in --disable-optimize builds:

gfx/harfbuzz/src/hb-private.hh:236:3 [-Wdeprecated-register] 'register' storage class specifier is deprecated
gfx/harfbuzz/src/hb-private.hh:252:3 [-Wdeprecated-register] 'register' storage class specifier is deprecated

Comment 5

[Behdad Esfahbod]

(In reply to Chris Peterson (:cpeterson) from comment #4)
> I will try to submit an upstream patch. Two additional clang warnings in
> --disable-optimize builds:
> 
> gfx/harfbuzz/src/hb-private.hh:236:3 [-Wdeprecated-register] 'register'
> storage class specifier is deprecated
> gfx/harfbuzz/src/hb-private.hh:252:3 [-Wdeprecated-register] 'register'
> storage class specifier is deprecated

Fixed upstream.

Comment 6

[Chris Peterson [:cpeterson]]

Thanks, Behdad! :)