Suppress clang and gcc warnings in third-party code: harfbuzz

RESOLVED WORKSFORME

Status

()

defect
P4
normal
RESOLVED WORKSFORME
6 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

gfx/harfbuzz/src/hb-common.cc:238:6 [-Wunused-function] unused function 'free_langs'
Attachment #8391831 - Flags: review?(jdaggett)
Might be better to propose a patch upstream, rather than just suppressing the warning here. The free_langs() function could be wrapped in #ifdef HAVE_ATEXIT, just like the only callsite.
Fixed upstream by merging Jonathan's pullrequest already.
Comment on attachment 8391831 [details] [diff] [review]
suppress-harfbuzz-warnings.patch

I agree with Jonathan, I think it would be better to have something upstream. Clearing the review for now.
Attachment #8391831 - Flags: review?(jdaggett)
I will try to submit an upstream patch. Two additional clang warnings in --disable-optimize builds:

gfx/harfbuzz/src/hb-private.hh:236:3 [-Wdeprecated-register] 'register' storage class specifier is deprecated
gfx/harfbuzz/src/hb-private.hh:252:3 [-Wdeprecated-register] 'register' storage class specifier is deprecated
(In reply to Chris Peterson (:cpeterson) from comment #4)
> I will try to submit an upstream patch. Two additional clang warnings in
> --disable-optimize builds:
> 
> gfx/harfbuzz/src/hb-private.hh:236:3 [-Wdeprecated-register] 'register'
> storage class specifier is deprecated
> gfx/harfbuzz/src/hb-private.hh:252:3 [-Wdeprecated-register] 'register'
> storage class specifier is deprecated

Fixed upstream.
Thanks, Behdad! :)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
Depends on: 1012218
You need to log in before you can comment on or make changes to this bug.